[docs/telemetry] Unnecessary comma in HCL example #8817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @fhemberger ! |
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
pull bot
pushed a commit
to Reality2byte/vault
that referenced
this pull request
Aug 26, 2025
…corp#8911) * VAULT-38463: Addressing ldap pipeline failure * testing ldap tests * testing ldap tests * debugging ldap issue * testing pipeline * testing pipeline * testing pipeline * testing pipeline * testing pipeline * testing pipeline * testing pipeline * debugging ldap failure * debugging ldap failure * debugging pipeline * adding dependency for verify secrets * removing extra code * undo changes * undo changes Co-authored-by: Tin Vo <[email protected]>
pull bot
pushed a commit
to sigtrap/vault
that referenced
this pull request
Sep 11, 2025
…ain (hashicorp#9048) (hashicorp#9260) * improve auth/ldap TestRotateRootWithRotationUrl test case * add const * Update path_config_rotate_root_test.go * Backport VAULT-34830: enable the new workflow into ce/main (hashicorp#8681) * VAULT-34830: enable the new workflow (hashicorp#8661) * pipeline: various fixes for the cutover to the enterprise first workflow (hashicorp#8686) Various small fixes that were discovered when doing the cutover to the enterprise first merge workflow: - The `actions-docker-build` action infers enterprise metadata magically from the repository name. Use a branch that allows configuring the repo name until it's merged upstream. - Fix some CE-In-Enterprise outputs in our metadata job. - Pass the recurse depth flag correctly when creating backports - Set the package name when calling the `build-vault` composite action - Disallow merging changes into `main` and `release/*` when executing in the `hashicorp/vault` repository. This is a hack until PSS-909 is resolved. - Use self-hosted runners when testing arm64 CE containers in enterprise. Conflicts: .github/workflows/backport-automation-ent.yml .github/workflows/test-run-enos-scenario-containers.yml --------- * remove file that slipped in during the backport but before the changed file checks (hashicorp#8706) * UI: Creating Metadata card for configuration page (hashicorp#8679) (hashicorp#8709) * card setup * updating to pass in vals * remove test usage * actions(metadata): fix metadata version for ce (hashicorp#8713) (hashicorp#8714) * Add support for AES-CBC to transit (hashicorp#8367) (hashicorp#8741) * add key types and encryption for cbc * add decryption * start adding tests * add tests for policy functions * add convergent case * add enterprise check and key creation test cases * fix key generation and add import/export * add tests and fixes * add changelog * linter * refactor policy functions and fix IV * add ce change * fix function calls * fix factories in function call * fix IV test case * test fixes * add cbc keys to read * change iv * fix merge errors * make fmt * change error name and add iv error * fix tests * UI: Create version card (hashicorp#8710) (hashicorp#8744) * setup version card * folder restructure * Adding todos, removing test * [VAULT-38605] Add self-enrollment option to the TOTP Login MFA method (hashicorp#8711) (hashicorp#8731) * [VAULT-38601] Modify response to MFA enforced requests to enable TOTP self-enrollment (hashicorp#8723) (hashicorp#8746) * Fix token creation in a namespace (hashicorp#8461) (hashicorp#8747) * fix and test for token creation in namespace * add changelog * add nil check * change existing test to work with change * fix imports * add error and more specificity in changelog * enos(sample): don't double sample (hashicorp#8752) (hashicorp#8770) * enos: remove double sample observe * ci(build): fix notification on artifacts build failure * changelog: add hash link to changes that originate from enterprise (hashicorp#8745) (hashicorp#8775) * pipeline(backport): use --strategy-option=theirs (hashicorp#8767) (hashicorp#8780) * VAULT-37630: Recover as a copy (hashicorp#8640) (hashicorp#8798) * recover as a copy implementation * get policy tests passing * add helpers and testing support * fixes * revert a couple of changes * more tests * switch to query param * correctly update source path with the namespace * only add openapi recover source path if there's a path parameter * add changelog * check for no mount in path * [UI] VAULT-37386 Plugin management: General Settings Route + Templates (hashicorp#8726) (hashicorp#8801) * Move components and routes over to new PR * Move components to secrets-engine folder * Use native FormData * Update params that are passed in * Add loading state * Add comments * Update jsdoc description * Remove unused action * Remove debugger * Fix linting errors * Add version card component and fix merge conflict issues * VAULT-38193 Add database observations to Vault (hashicorp#8727) (hashicorp#8802) * VAULT-38193 database observations (WIP) * VAULT-38193 database observations * nil check * make it consistent * Clean up * update vault-plugin-secrets-openldap to v0.16.1 (hashicorp#8820) (hashicorp#8821) * update vault-plugin-secrets-openldap to v0.16.1 * changelog * VAULT-39129: Updating enos tutorial scenario link (hashicorp#8831) (hashicorp#8835) * [VAULT-39153] pipeline(backport): remove docs and pipeline from allowed ce inactive (hashicorp#8819) (hashicorp#8842) Docs have been moved since the tool was written so that exclusion is no longer needed. Since the defaults were added the `pipeline` group has expanded to include all `.github`, which we don't want to always backport. It seems unlike that `pipeline` tooling changes are likely to be required often on inactive branches so we'll exclude all together for now. * [VAULT-39157] enos(cloud): add basic vault cloud scenario (hashicorp#8828) (hashicorp#8847) * [VAULT-39157] enos(cloud): add basic vault cloud scenario Add the skeleton of a Vault Cloud scenario whereby we create an HCP network, Vault Cloud cluster, and admin token. In subsequent PR's we'll wire up building images, waiting on builds, and ultimately fully testing the resulting image. * copywrite: add headers --------- * Upgrade to CRT schema 2 to fix crt-report-dispatch event (hashicorp#8572) (hashicorp#8809) * api/client: support setting extra headers with new logical request interface. (hashicorp#8808) (hashicorp#8858) * [VAULT-39208]: actions: update action pins (hashicorp#8864) (hashicorp#8865) * UI: Create Lease Duration card component + style updates (hashicorp#8815) (hashicorp#8870) * updating components to use hds flex, removing custom css * creating layout, updating fields to use select instead of dropdown * conditional render, remove commented code * adding external link * update handlers and style * updating general settings layout so TTL doesnt stretch other cards * typo * [UI] Cubbyhole List View Bug (hashicorp#8859) (hashicorp#8871) * fixes issue with cubbyhole list view throwing error in child namespace * updates to use engineType prop * Disallow writing of barrier keyring if seals aren't healthy (hashicorp#8707) (hashicorp#8885) * Set the full rewrap context for barrier keyring writes * Retain some logging at Trace but get rid of the overall context pattern. Apply correct ctx transform * changelog * remove logger * here too * remove other unnecessary changes * VAULT-38888 Add prefix vault to metric summary definitions into main (hashicorp#8725) (hashicorp#8892) * VAULT-38888 Add prefix vault to metric summary definitions * VAULT-38888 Add changelog for fix * Edit changelog file name --------- * [VAULT-39235]: pipeline(changed-files): don't group underscore prefixed changelogs as enterprise only files (hashicorp#8906) (hashicorp#8934) Don't categorize changelog files that begin with an underscore as enterprise only, otherwise they'll be removed when backporting changes to CE. Since we want to include links to commit SHAs in the changelog we have to create the changelog in the context of CE and thus need to backport all of those changes. We also fix a few Go tests that hand not been updated to handle the updated default inactive CE groups. * VAULT-39010 Adding new go-discover logic (hashicorp#8884) (hashicorp#8931) * testing new go-discover logic * add changelog * Delete website/content/partials/known-issues/aws-auto-join-fails.mdx * Backport bump go-getter to 1.7.9 into ce/main (hashicorp#8926) * bump go-getter to 1.7.9 (hashicorp#8899) * bump go-getter to 1.7.9 * add changelog * go mod tidy --------- * VAULT-38463: Addressing ldap pipeline failure (hashicorp#8817) (hashicorp#8911) * VAULT-38463: Addressing ldap pipeline failure * testing ldap tests * testing ldap tests * debugging ldap issue * testing pipeline * testing pipeline * testing pipeline * testing pipeline * testing pipeline * testing pipeline * testing pipeline * debugging ldap failure * debugging ldap failure * debugging pipeline * adding dependency for verify secrets * removing extra code * undo changes * undo changes * Backport [VAULT-38910]: upgrade docker package to resolve GO-2025-3829 into ce/main (hashicorp#8875) * [VAULT-38910]upgrade docker package to resolve GO-2025-3829 (hashicorp#8642) * bump github.com/hashicorp/go-secure-stdlib/plugincontainer to v0.4.2 * bump github.com/docker/docker to v28.3.3+incompatible * go mod tidy --------- * manually copy over missing changelogs for main (hashicorp#8956) * Improve error messages in TestRotateRootWithRotationUrl for BindDN and URL checks * Use bitnamilegacy cassandra image for tests (hashicorp#8984) (hashicorp#8985) * use default cassandra image for tests * switch to bitnamilegacy * [VAULT-39237] actions(generate-changelog) generate changelogs in ce for active ce versions (hashicorp#8973) (hashicorp#8976) Update our changelog generator to dynamically decide which repository context that it should use when generating the changelog. If the version given corresponds to an active CE branch then we generate the changelog in the context of `hashicorp/vault` with the `note-ce.md` template. If the version corresponds to an enterprise only branch we generate the changelog in the context of `hashicorp/vault-enterprise` with the `note-ent.md` template. The reason we do all of this is so that we can add commit links to changelogs that for changes that are actually in community editions. * UI: Moving settings/mount-backend-form to secrets/mounts (hashicorp#8975) (hashicorp#8998) * adding route and replacing old route usage * adding comments * updating secrets tests to new route * Update CHANGELOG.md for 1.20.3 1.19.9 1.18.14 and 1.16.25 (hashicorp#31527) * changelog: fix commit URL in CE generated template (hashicorp#9010) (hashicorp#9013) * VAULT-38463: Fix ldap failure (hashicorp#8996) (hashicorp#9001) * Backport [VAULT-38600] Fix the name of the CE stub for mfaLoginEnterprisePaths into ce/main (hashicorp#9021) * Update CHANGELOG.md (hashicorp#31528) added "Enterprise" to 1.19, 1.18 and 1.16 minor releases * VAULT-38796, VAULT-38889 reformat observation schema to version 2 (hashicorp#9006) (hashicorp#9023) * [VAULT-39267] actions(slack): migrate to v2 action (hashicorp#8964) (hashicorp#8990) * VAULT-37633: Database static role recover operations (hashicorp#8922) (hashicorp#8982) * initial implementation * fix * tests * changelog * fix vet errors * pr comments * [VAULT-38600] Create TOTP Login MFA credential self-enrollment API endpoint (hashicorp#8970) (hashicorp#8999) * VAULT-36947: Support force unloading a snapshot (hashicorp#8740) (hashicorp#9036) * portion of changes for autoloading * add test checking for panic * add endpoint for force unloading * separate method for force unload * changelog * don't redefine constants * VAULT-39294: Deprecate recover_snapshot_id query param and use a header instead (hashicorp#8834) (hashicorp#9042) * deprecate snapshot query params, use a header instead * keep read query param, but deprecate recover one * fix test * remove list change * add changelog * rename header, allow request method * update changelog * VAULT-37632 allow restoring SSH CA from loaded snapshot (hashicorp#8581) (hashicorp#9034) * allow restoring ssh config/ca * add some unit tests * address PR review * imports and test upgrades * linter complaints * add PR comment and linter fixes * address review * Revert "Merge hashicorp#31503 into main" This reverts commit 6f2ffcf64cd6a01cdbf685db296053adb428e26b, reversing changes made to 681d1d5c7a2298a8b5dd403554dec2e98c3ce971. * Update path_config_rotate_root_test.go --------- Signed-off-by: Ryan Cragun <[email protected]> Co-authored-by: Ryan Cragun <[email protected]> Co-authored-by: jadeidev <[email protected]> Co-authored-by: Dan Rivera <[email protected]> Co-authored-by: Rachel Culpepper <[email protected]> Co-authored-by: Kuba Wieczorek <[email protected]> Co-authored-by: miagilepner <[email protected]> Co-authored-by: Kianna <[email protected]> Co-authored-by: Violet Hynes <[email protected]> Co-authored-by: John-Michael Faircloth <[email protected]> Co-authored-by: Tin Vo <[email protected]> Co-authored-by: james-warren0 <[email protected]> Co-authored-by: Ben Ash <[email protected]> Co-authored-by: Jordan Reimer <[email protected]> Co-authored-by: Scott Miller <[email protected]> Co-authored-by: roh-ag <[email protected]> Co-authored-by: JMGoldsmith <[email protected]> Co-authored-by: Josh Black <[email protected]> Co-authored-by: Luciano Di Lalla <[email protected]> Co-authored-by: Robert <[email protected]> Co-authored-by: Bruno Oliveira de Souza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.