Skip to content

Add validation to enforce skip_cleanup=false cannot be used with backends #36857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Apr 4, 2025

(Work split out of #36848)

This PR:

  • Adds validation to stop users setting skip_cleanup=false in a run block with a backend block
    • This is because using a backend block implies skip_cleanup=true
    • We could pivot to making backend and skip_cleanup mutually exclusive?
  • Adds tests for that validation, and also to show it's ok to set skip_cleanup=true in a run block with a backend block

@SarahFrench SarahFrench added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Apr 4, 2025
@SarahFrench SarahFrench marked this pull request as ready for review April 4, 2025 22:54
@SarahFrench SarahFrench requested a review from a team as a code owner April 4, 2025 22:54
@SarahFrench SarahFrench merged commit 36a9fc1 into f-controlling-destroys Apr 14, 2025
8 checks passed
@SarahFrench SarahFrench deleted the sarah/backend-skip-cleanup-validation branch April 14, 2025 09:42
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants