Add additional validation that the backend used in a run is a supported type #36648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
SarahFrench
commented
Mar 6, 2025
| for _, tf := range config.Module.Tests { | ||
| bucketHashes := make(map[int]string) | ||
| // Use an ordered list of backends, so that errors are raised by 2nd+ time | ||
| // that a backend config is used in a file. | ||
| for _, bc := range orderBackendsByDeclarationLine(tf.BackendConfigs) { | ||
| f := backendInit.Backend(bc.Backend.Type) | ||
| if f == nil { | ||
| detail := fmt.Sprintf("There is no backend type named %q.", bc.Backend.Type) | ||
| if msg, removed := backendInit.RemovedBackends[bc.Backend.Type]; removed { |
There was a problem hiding this comment.
This validation needs to be here because it also depends on internal/backend/init, which is hard to import elsewhere
dsa0x
approved these changes
Mar 6, 2025
|
Thanks! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #36541
Now there is validation to ensure that:
artifactory,etcd)Target Release
1.12.x
CHANGELOG entry
Will add a changelog in the final PR into main