Add ephemeral resources to the Terraform language #35728
Conversation
jbardin
force-pushed
the
jbardin/ephemeral-resources
branch
from
baa058c to
95124db
Compare
| var ephemeralBlockSchema = &hcl.BodySchema{ | ||
| Attributes: commonResourceAttributes, | ||
| Blocks: []hcl.BlockHeaderSchema{ | ||
| {Type: "lifecycle"}, |
There was a problem hiding this comment.
| {Type: "lifecycle"}, | |
| {Type: "lifecycle"}, // reserved for future use |
| case "precondition", "postcondition": | ||
| cr, moreDiags := decodeCheckRuleBlock(block, override) | ||
| diags = append(diags, moreDiags...) | ||
|
|
||
| moreDiags = cr.validateSelfReferences(block.Type, r.Addr()) | ||
| diags = append(diags, moreDiags...) | ||
|
|
||
| switch block.Type { | ||
| case "precondition": | ||
| r.Preconditions = append(r.Preconditions, cr) | ||
| case "postcondition": | ||
| r.Postconditions = append(r.Postconditions, cr) | ||
| } |
There was a problem hiding this comment.
I'm not sure how much complexity/effort will be required to make conditions work for the new resource type but we could also just reserve these in the language initially. You are more likely to know the answer though, so I'm assuming if you are proposing to keep it like this, it's not too complex.
There was a problem hiding this comment.
Aside from optimistically hoping that the implementation isn't too difficult (these are still just a resource type after all), they also seem useful when the values are not easily extracted by the user for other debugging purposes. If there is any problem implementing later steps we can always reserve the block names to prevent their use. These first commits are all preliminary anyway, there will probably be some changes as all the pieces are integrated.
| @@ -18,6 +18,8 @@ import ( | |||
| "github.com/hashicorp/terraform/internal/addrs" | |||
| "github.com/hashicorp/terraform/internal/depsfile" | |||
| "github.com/hashicorp/terraform/internal/getproviders/providerreqs" | |||
|
|
|||
| _ "github.com/hashicorp/terraform/internal/logging" | |||
There was a problem hiding this comment.
Was this intentional or was it just to temporarily aid debugging in test environment?
There was a problem hiding this comment.
You have to import the internal logging package somewhere to initialize the default logger, so any package tested in isolation needs this to not print all logs during tests.
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This add ephemeral resources to the configuration language. Terraform can now parse ephemeral resource configuration and references.