lang: stabilise ephemeral values experiment #35636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stabilise the ephemeral values experiment and ephemeralasnull experimental function.
kmoe
force-pushed
the
kmoe/stabilise-ephemeral-experiment
branch
from
89519b6 to
08f8708
Compare
kmoe
force-pushed
the
kmoe/stabilise-ephemeral-experiment
branch
from
08f8708 to
cfa1e2b
Compare
kmoe
force-pushed
the
kmoe/stabilise-ephemeral-experiment
branch
from
cfa1e2b to
58c2d36
Compare
kmoe
force-pushed
the
kmoe/stabilise-ephemeral-experiment
branch
from
58c2d36 to
412e58d
Compare
As the final step in stabilising the ephemeral values experiment, we can remove the separate code path for handling input variables supplied via -var and -var-file during apply. The intent here is conveyed in the tests: when applying a saved plan, all ephemeral variables set in the plan (the "apply-time variables"), must be set, and no others. As per the TODO copied from the prototype, there is some more work to be done here in making the handling of undeclared variables during apply as sophisticated as that during plan, emitting helpful warnings (for example) when input variables are supplied unnecessarily via environment variables.
kmoe
force-pushed
the
kmoe/stabilise-ephemeral-experiment
branch
from
412e58d to
8036e99
Compare
radeksimko
approved these changes
Aug 26, 2024
radeksimko
force-pushed
the
kmoe/stabilise-ephemeral-experiment
branch
from
114851c to
43b04e4
Compare
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to test.
The first commit contains trivial changes along with refactoring the handling of
terraform.applyingandterraform.workspacealong the lines described in the deleted comment.The second commit was a little more involved than I'd hoped, simplifying the handling of apply time input vars. More work to do here as described in the commit message, but I hope this will make it easier to work on the feature.