-
Notifications
You must be signed in to change notification settings - Fork 6
Introduce Component and ComponentPackage types #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This provides a structured way to handle component addresses in the Terraform registry, enabling validation and error reporting. The new types and functions facilitate the installation workflow for components. - Added Component and ComponentPackage structs to represent registry components and their addresses. - Implemented ParseComponentSource function to parse and validate component registry addresses. - Created unit tests for ParseComponentSource to ensure correct parsing and error handling.
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
radeksimko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I was to put a hat of a public consumer with no further/insider context I'd be puzzled about what is "component" and how it fits within the current model of modules and providers.
On that note - shall we add some brief explanation with examples to the Readme.md?
@radeksimko I've updated the readme inline with existing content for modules. Does this suffice? |
radeksimko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect, thanks for the added docs @jpogran-hashi 👍🏻
Related Issue
Fixes #
Description
This provides a structured way to handle component addresses
in the Terraform registry, enabling validation and error
reporting. The new types and functions facilitate the
installation workflow for components.
components and their addresses.
component registry addresses.
and error handling.
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.