Merged
Conversation
arybolovlev
reviewed
Jul 24, 2025
Collaborator
arybolovlev
left a comment
arybolovlev
left a comment
There was a problem hiding this comment.
All in all, this looks great! I have left a small comment, and I was wondering -- would it make sense to add a test that specifically validates the case where take_ownership is set to true?
helm/resource_helm_release.go
Outdated
| "take_ownership": schema.BoolAttribute{ | ||
| Optional: true, | ||
| Computed: true, | ||
| Default: booldefault.StaticBool(false), |
Collaborator
There was a problem hiding this comment.
Would it make sense to use a value from the defaultAttributes map here? Maybe in a few other places in this PR too?
jrhouston
approved these changes
Jul 30, 2025
arybolovlev
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
This PR adds support for the
take_ownershipattribute in thehelm_releaseresource.Acceptance tests
Release Note
Release note for CHANGELOG:
References
Community Note