Skip to content

Add upgrade_install support#1675

Merged
jrhouston merged 6 commits intohashicorp:mainfrom
jaylonmcshan19-x:upgrade_install
Jul 16, 2025
Merged

Add upgrade_install support#1675
jrhouston merged 6 commits intohashicorp:mainfrom
jaylonmcshan19-x:upgrade_install

Conversation

@jaylonmcshan19-x
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

add upgrade_install support

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

#1642

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@jaylonmcshan19-x jaylonmcshan19-x marked this pull request as ready for review July 14, 2025 15:12
@jaylonmcshan19-x jaylonmcshan19-x requested a review from a team as a code owner July 14, 2025 15:12
})
}

func TestAccResourceRelease_upgradeInstall_coldstart(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the SDKv2 codebase this feature has an additional test: 723cb76#diff-0c630859c0a0648a5a7cd178d9b8d011108f16648cd8fc6b651390cec95ebc56R151

Copy link
Collaborator

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also docs missing, see here: 723cb76#diff-dfa3549e8fadc7546724a4c34de13f108ae02f7aca3d27d0e2054171fb6d09ebR330-R369

edit: docs are already there

@github-actions github-actions bot added size/XL and removed size/L labels Jul 15, 2025
@iBrandyJackson iBrandyJackson requested a review from jrhouston July 16, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants