Revert "Bump github.com/hashicorp/terraform-plugin-framework from 1.16.0 to 1.16.1 in the terraform-devex group across 1 directory"

[jar-b]

Reverts #44493

The additional error diagnostics added in this version have uncovered some discrepancies between how the AWS provider implemented resource identity support for Plugin Framework resources, and the expectations held by the upstream library. Specifically, the library assumes that a resource implements the ResourceWithIdentity interface when identity is fully supported, and always returns a non-nil schema.

In versions v6.0.0 to current, the provider has implemented an IdentitySchema method on all Plugin Framework resources by wrapping the base resource implementation, therefore satisfying the ResourceWithIdentity interface. A resource was only considered supported when the schema contained greater than 0 attributes.

This difference in assumptions went undetected to this point because the upstream library allowed null identities to be written to state, as would be the case with any resource which the provider considered "unimplemented" but plugin framework would treat as implemented with an empty identity schema (0 attributes). With the introduction of new error diagnostics for this case, the provider will need to refactor how Plugin Framework resources are wrapped before proceeding with the upgrade of this package.

Relates hashicorp/terraform-plugin-framework#1193

---

Example of a newly failing test with this library upgrade.

% make t K=lambda T=TestAccLambdaFunctionRecursionConfig_basic
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-identity-interceptor-fw 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunctionRecursionConfig_basic'  -timeout 360m -vet=off
2025/10/01 15:26:04 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/01 15:26:04 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLambdaFunctionRecursionConfig_basic
=== PAUSE TestAccLambdaFunctionRecursionConfig_basic
=== CONT  TestAccLambdaFunctionRecursionConfig_basic
    function_recursion_config_test.go:36: Step 1/2 error: Error running apply: exit status 1

        Error: Missing Resource Identity After Create

          with aws_lambda_function_recursion_config.test,
          on terraform_plugin_test.tf line 41, in resource "aws_lambda_function_recursion_config" "test":
          41: resource "aws_lambda_function_recursion_config" "test" {

        The Terraform Provider unexpectedly returned no resource identity data after
        having no errors in the resource create. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
--- FAIL: TestAccLambdaFunctionRecursionConfig_basic (30.13s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/lambda     36.818s

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v6.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.