Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

add import subcommand #117

Merged
merged 2 commits into from
Feb 4, 2020
Merged

add import subcommand #117

merged 2 commits into from
Feb 4, 2020

Conversation

vvakame
Copy link
Contributor

@vvakame vvakame commented Nov 21, 2019

hi, I want to use terraform import fastly_service_v1.xxx xxxx.
because I want to execute the plan after getting the same state as the real fastly service.

@vvakame
Copy link
Contributor Author

vvakame commented Nov 22, 2019

or use backend?

@cauealvesbraz
Copy link

cauealvesbraz commented Jan 27, 2020

Hello @vvakame, thanks for this submission.

I have the same issue when trying to use terraform import ... on step.

Did you solve this issue without a backend implementation?

@cauealvesbraz
Copy link

cauealvesbraz commented Jan 27, 2020

Hey @sudomateo, how are you?

First for all, congrats for this project 👏

Did you have any update about this Pull Request?

Adding terraform import as subcommand is very useful 👍

@vvakame
Copy link
Contributor Author

vvakame commented Jan 27, 2020

I'm using GCS backend finally...

@cauealvesbraz
Copy link

I'm using the AWS as provider and I didn't want to create a custom step for use terraform import...

Any concern for this Pull Request @sudomateo?

Copy link
Contributor

@sudomateo sudomateo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. I see a minor change necessary.

@cauealvesbraz
Copy link

@vvakame Will you be able to make the changes?

Co-Authored-By: Matthew Sanabria <[email protected]>
@vvakame vvakame requested a review from sudomateo January 31, 2020 08:02
Copy link

@cauealvesbraz cauealvesbraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cauealvesbraz
Copy link

@sudomateo Could you review again?

@cauealvesbraz
Copy link

Ping @sudomateo

@sudomateo
Copy link
Contributor

@cauealvesbraz Appreciate the pings for visibility. I'll review this when I'm back in the office on Monday. Don't worry it's still on my radar.

@sudomateo sudomateo merged commit 271eb39 into hashicorp:master Feb 4, 2020
@vvakame vvakame deleted the import-subcommand branch February 5, 2020 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants