Add AddrV6IPAddr to support link-local addresses#115
Merged
DanStough merged 2 commits intohashicorp:mainfrom Mar 21, 2024
Merged
Add AddrV6IPAddr to support link-local addresses#115DanStough merged 2 commits intohashicorp:mainfrom
DanStough merged 2 commits intohashicorp:mainfrom
Conversation
|
|
DanStough
approved these changes
Mar 21, 2024
Contributor
DanStough
left a comment
DanStough
left a comment
There was a problem hiding this comment.
Thank you for the PR. Looks solid to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPv6 link-local IPs must be qualified with a zone (interface) to be useful. If the mDNS query is not bound to a specific interface, it's not possible in the current implementation to determine the correct zone from the ServiceEntry. This PR uses the source address of the mDNS response packet to determine the zone. This zone info is not carried by the net.IP datatype used for the current AddrV6 field, so this PR deprecates that address and adds the AddrV6IPAddr field of type *net.IPAddr.