Merged
Conversation
radeksimko
reviewed
Jul 14, 2025
Member
radeksimko
left a comment
radeksimko
left a comment
There was a problem hiding this comment.
Impressive improvement.
Having tinkered with this PR a bit, I'm assuming that big part of the memory allocations come from inside of bytes.Buffer. A bit unfortunate but I suppose that's the cost for the convenient API which we are now giving up here.
Aside from that mostly stylistic comment in-line this LGTM and I'd be happy to merge when that is addressed.
It would be interesting to see the impact of storing the parsed version parts as bytes also and only converting to strings when necessary - just an idea for another PR. 🤔
Contributor
Author
|
Once this is merged, will raise an another PR with storing the parsed version parts as bytes array, definitely can reduce the number of allocs/op and B/op by then. |
mallikabandaru
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of using the strings package for construction version string, used the bytes[] which has drastically reduced the number of allocs/op and B/op
There is still room for improvement. More on here
Related Issue
#118
How Has This Been Tested?
With Bytes Implementation
With String Implementation
