-
Notifications
You must be signed in to change notification settings - Fork 49
[Docs] Filter Bar component #3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dchyun/filter-bar-component
Are you sure you want to change the base?
[Docs] Filter Bar component #3396
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fcce535 to
64c48b9
Compare
LilithJames-HDS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, I left some comments and some nitpicky little things
website/docs/components/filter-bar/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/filter-bar/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/filter-bar/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
|
|
||
| - For complex query builder features. | ||
|
|
||
| ## Overlap with the Filter pattern guidance <!--Consider a different headline --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I conjunction with this, should we have a revision to the Filter Patterns page that leads to this component? Maybe a banner on that page to alert anyone who is looking around and not aware that this is a newly available component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's exactly what I was thinking is adding a banner to the Filter Patterns page kind of directing consumers to the component, I just have yet to get that added in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this as well
|
|
||
| <!-- Should something be included about truncation? --> | ||
|
|
||
| ## Filter dropdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to have an image of the entire menu here so consumers can see the left and right panels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a basic example
website/docs/components/filter-bar/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/filter-bar/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,183 @@ | |||
| The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[todo] We could link this directly to the filter bar examples in the adv table docs once I create those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards. | |
| The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table?tab=code#filtering), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards. |
This can be linked directly now that I have added the adv table filtering docs
website/docs/components/filter-bar/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
|
|
||
| If necessary, the default formatting within the Tag can be overidden with custom text. This can be useful if the label of the parameter is an irregular plural, if the parameter reads more naturally with certain punctuation or grammar, or for product-specific reasons. | ||
|
|
||
| <!-- @dylan could you help me out a bit with this? --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[todo] Once I implement this on the dev side to not just be for custom filters we can add in some more specifics if we need to, but I think you covered a lot of it.
Do we want to talk about custom filters at all?
website/docs/components/filter-bar/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/filter-bar/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/filter-bar/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/filter-bar/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
5515833 to
6d5f0b7
Compare
Co-authored-by: Lilith James <[email protected]>
…nes.md Co-authored-by: Dylan Hyun <[email protected]>
e103253 to
64d27e1
Compare
| </C.Property> | ||
| </Doc::ComponentApi> | ||
|
|
||
| ### Filter Types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Note] We haven't really documented something like the @filters object where its shape can changed based on the type. I tried laying things out here, but open to other ideas of how to document it.
| @@ -0,0 +1,64 @@ | |||
| ## Conformance Rating | |||
|
|
|||
| <Doc::Badge @type="success">Conformant</Doc::Badge> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Question] @shleewhite is this a correct statement? Also when you have a moment could you review this page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorytindall do we want to add anything to the AdvTable guidelines on the filtering? Or add anything the filter bar or empty state to the specifications?
| @@ -0,0 +1,183 @@ | |||
| The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards. | |
| The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table?tab=code#filtering), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards. |
This can be linked directly now that I have added the adv table filtering docs
|
|
||
| !!! Callout | ||
|
|
||
| The `type` property is available in Figma only. The Ember component can be passed to the [Advanced Table](#add-a-link-when-ready) as a contextual component, or used on it's own in which case the styling will adjust accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The `type` property is available in Figma only. The Ember component can be passed to the [Advanced Table](#add-a-link-when-ready) as a contextual component, or used on it's own in which case the styling will adjust accordingly. | |
| The `type` property is available in Figma only. The Ember component can be passed to the [Advanced Table](/components/table/advanced-table?tab=code#filtering) as a contextual component, or used on it's own in which case the styling will adjust accordingly. |
[todo] Update link to adv table filtering
📌 Summary
Adds documentation for the new
FilterBarcomponent from #3386Preview pages
🔗 External links
Jira ticket: HDS-4592
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.