Skip to content

Conversation

@dchyun
Copy link
Contributor

@dchyun dchyun commented Dec 2, 2025

📌 Summary

Adds documentation for the new FilterBar component from #3386

Preview pages

🔗 External links

Jira ticket: HDS-4592


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Dec 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hds-showcase Ready Ready Preview Dec 19, 2025 8:32pm
hds-website Ready Ready Preview Dec 19, 2025 8:32pm

Copy link
Contributor

@LilithJames-HDS LilithJames-HDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, I left some comments and some nitpicky little things


- For complex query builder features.

## Overlap with the Filter pattern guidance <!--Consider a different headline -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I conjunction with this, should we have a revision to the Filter Patterns page that leads to this component? Maybe a banner on that page to alert anyone who is looking around and not aware that this is a newly available component

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's exactly what I was thinking is adding a banner to the Filter Patterns page kind of directing consumers to the component, I just have yet to get that added in

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this as well


<!-- Should something be included about truncation? -->

## Filter dropdown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to have an image of the entire menu here so consumers can see the left and right panels

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a basic example

@@ -0,0 +1,183 @@
The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[todo] We could link this directly to the filter bar examples in the adv table docs once I create those.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards.
The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table?tab=code#filtering), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards.

This can be linked directly now that I have added the adv table filtering docs


If necessary, the default formatting within the Tag can be overidden with custom text. This can be useful if the label of the parameter is an irregular plural, if the parameter reads more naturally with certain punctuation or grammar, or for product-specific reasons.

<!-- @dylan could you help me out a bit with this? -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[todo] Once I implement this on the dev side to not just be for custom filters we can add in some more specifics if we need to, but I think you covered a lot of it.

Do we want to talk about custom filters at all?

</C.Property>
</Doc::ComponentApi>

### Filter Types
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Note] We haven't really documented something like the @filters object where its shape can changed based on the type. I tried laying things out here, but open to other ideas of how to document it.

@@ -0,0 +1,64 @@
## Conformance Rating

<Doc::Badge @type="success">Conformant</Doc::Badge>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question] @shleewhite is this a correct statement? Also when you have a moment could you review this page?

Copy link
Contributor Author

@dchyun dchyun Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorytindall do we want to add anything to the AdvTable guidelines on the filtering? Or add anything the filter bar or empty state to the specifications?

@@ -0,0 +1,183 @@
The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards.
The Filter Bar is used to apply and display filters to a data set. It is most often used in conjunction with the [Advanced Table](/components/table/advanced-table?tab=code#filtering), but is flexible enough to support different data sets and rendering methods such as in a list or grid of cards.

This can be linked directly now that I have added the adv table filtering docs


!!! Callout

The `type` property is available in Figma only. The Ember component can be passed to the [Advanced Table](#add-a-link-when-ready) as a contextual component, or used on it's own in which case the styling will adjust accordingly.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `type` property is available in Figma only. The Ember component can be passed to the [Advanced Table](#add-a-link-when-ready) as a contextual component, or used on it's own in which case the styling will adjust accordingly.
The `type` property is available in Figma only. The Ember component can be passed to the [Advanced Table](/components/table/advanced-table?tab=code#filtering) as a contextual component, or used on it's own in which case the styling will adjust accordingly.

[todo] Update link to adv table filtering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-website Content updates to the documentation website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants