-
Notifications
You must be signed in to change notification settings - Fork 49
Bump node to 24 #3358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump node to 24 #3358
Conversation
nvm automatically climb the parent tree looking for a `.nvmrc` file and we have one at the root of the repo
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
didoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the following packages have still an older version of the engines entry:
packages/components/package.jsonpackages/codemods/package.json
while these don't have entries at all:
packages/tokens/package.jsonpackages/flight-icons/package.json
How does it work? Why this difference? (for my own learning)
For packages, the |
π Summary
Note
Vercel
doesn't yet support v24 β it's due in November, so we'll have to wait a bit longer before being able to upgradejust made v24 available, so we're now good to go with this PR.tool-versionto enforce node and pnpm versions toasdfusersThis bump will unblock a set of PRs (#3343, #3262, #3137) meant to bring our GitHub Actions to date.
π External links
Jira ticket: HDS-5564
π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.
π PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.