Skip to content

Conversation

@alex-ju
Copy link
Member

@alex-ju alex-ju commented Nov 7, 2025

πŸ“Œ Summary

Note

Vercel doesn't yet support v24 – it's due in November, so we'll have to wait a bit longer before being able to upgrade just made v24 available, so we're now good to go with this PR

  • Bump Node.js to latest LTS (v24) across the repo (dev tools and actions/workflows)
  • Committing .tool-version to enforce node and pnpm versions to asdf users

This bump will unblock a set of PRs (#3343, #3262, #3137) meant to bring our GitHub Actions to date.

πŸ”— External links

Jira ticket: HDS-5564


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

πŸ“‹ PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Nov 26, 2025 10:15am
hds-website Ready Ready Preview Nov 26, 2025 10:15am

@alex-ju alex-ju marked this pull request as ready for review November 26, 2025 10:16
@alex-ju alex-ju requested a review from a team as a code owner November 26, 2025 10:16
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the following packages have still an older version of the engines entry:

  • packages/components/package.json
  • packages/codemods/package.json

while these don't have entries at all:

  • packages/tokens/package.json
  • packages/flight-icons/package.json

How does it work? Why this difference? (for my own learning)

@alex-ju
Copy link
Member Author

alex-ju commented Nov 26, 2025

I see that the following packages have still an older version of the engines entry:

  • packages/components/package.json
  • packages/codemods/package.json

while these don't have entries at all:

  • packages/tokens/package.json
  • packages/flight-icons/package.json

How does it work? Why this difference? (for my own learning)

For packages, the engines.node definition signals to consumers what Node version we support. For tokens and flight-icons Node is not required.

@alex-ju alex-ju merged commit 72ca6c9 into main Dec 1, 2025
22 of 23 checks passed
@alex-ju alex-ju deleted the alex-ju/bump-node-to-24 branch December 1, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants