Skip to content

Conversation

@dduzgun-security
Copy link
Collaborator

@dduzgun-security dduzgun-security commented Aug 18, 2025

Description

https://github.com/mitchellh/mapstructure is now a public archive, this PR aims to migrate to a fork of it https://github.com/go-viper/mapstructure (v2) which is maintained and gets frequent security patches.

Ref: PSA-2107

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@dduzgun-security dduzgun-security requested a review from a team as a code owner August 18, 2025 19:54
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies pr/dependencies PR specifically updates dependencies of project theme/envoy/xds Related to Envoy support theme/contributing Additions and enhancements to community contributing materials theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics labels Aug 18, 2025
@dduzgun-security dduzgun-security added the backport/all Apply backports for all active releases per .release/versions.hcl label Aug 18, 2025
sreeram77
sreeram77 previously approved these changes Aug 26, 2025
Copy link
Member

@sreeram77 sreeram77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dduzgun-security
Copy link
Collaborator Author

@sreeram77 I've resolved few conflicts with main. Can you re-approve once the CI is green please? I'll merge it after

@dduzgun-security dduzgun-security merged commit 908e826 into main Sep 8, 2025
110 checks passed
@dduzgun-security dduzgun-security deleted the deps/update-mapstructure branch September 8, 2025 15:39
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.21 This release series is longer active on CE, use backport/ent/1.21 backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent backport/ent/1.20 backport to ent 1.20 labels Sep 8, 2025
@dduzgun-security dduzgun-security restored the deps/update-mapstructure branch September 8, 2025 15:41
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @dduzgun-security! a backport is missing for this PR [22581] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

4 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @dduzgun-security! a backport is missing for this PR [22581] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @dduzgun-security! a backport is missing for this PR [22581] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @dduzgun-security! a backport is missing for this PR [22581] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @dduzgun-security! a backport is missing for this PR [22581] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

LakshmiNarayananDesikan pushed a commit that referenced this pull request Sep 17, 2025
* deps: migrate mapstructure to go-viper

* go mod tidy

* add changelog

* fix test

* go mod tidy

* fix test

* fix test

* go mod tidy
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @dduzgun-security! a backport is missing for this PR [22581] for versions [1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

2 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @dduzgun-security! a backport is missing for this PR [22581] for versions [1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @dduzgun-security! a backport is missing for this PR [22581] for versions [1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent backport/ent/1.20 backport to ent 1.20 backport/1.21 This release series is longer active on CE, use backport/ent/1.21 pr/dependencies PR specifically updates dependencies of project theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/contributing Additions and enhancements to community contributing materials theme/envoy/xds Related to Envoy support theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants