refactor(plugin): convert grpc error codes into Boundary error codes #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
talanknight
suggested changes
Mar 14, 2022
There was a problem hiding this comment.
This looks like it is moving our errors for plugins in a good direction.
Could you also provide in the PR a before/after example of what aws/azure invalid arguments error looks like? This can show us what state we have arrived at in terms of readability of the errors and help us evaluate if we should continue or pause on our path towards more readable errors for plugins.
| @@ -122,7 +122,14 @@ func (r *Repository) CreateCatalog(ctx context.Context, c *HostCatalog, _ ...Opt | |||
| if !pluginCalledSuccessfully { | |||
| plgResp, err = plgClient.OnCreateCatalog(ctx, &plgpb.OnCreateCatalogRequest{Catalog: plgHc}) | |||
| if err != nil { | |||
| if status.Code(err) != codes.Unimplemented { | |||
| switch { | |||
There was a problem hiding this comment.
Can you add tests to verify these behave as expected? For the changes in this file and the repository_host_set file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.