fix: 🐛 add aria-description to edit User detail btn to fix a11y bug #3113
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the aria-description to the Edit form button in the Edit user details form ✅ Closes: FE-112
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
10 tasks
ZedLi
reviewed
Dec 16, 2025
This reverts unnecessary translation and updates aria-description for the User edit button ✅ Closes: FE-112
ZedLi
approved these changes
Dec 17, 2025
Collaborator
ZedLi
left a comment
ZedLi
left a comment
There was a problem hiding this comment.
Looks good, thanks for the update!
ZedLi
requested changes
Dec 17, 2025
Collaborator
ZedLi
left a comment
ZedLi
left a comment
There was a problem hiding this comment.
I misread this PR, we shouldn't be hard coding the aria description to user for all buttons, this should be passed through by the consumer
This passes the @ariaDescription down to the edit-toggle component instead it down to the edit button. ✅ Closes: FE-112
✅ Closes: FE-112
venusang
changed the title
ZedLi
previously approved these changes
Dec 17, 2025
Collaborator
ZedLi
left a comment
ZedLi
left a comment
There was a problem hiding this comment.
Looks good, there was just one typo
addons/rose/tests/integration/components/rose/form/actions/edit-toggle-test.js
Outdated
Show resolved
Hide resolved
…t-toggle-test.js Co-authored-by: Zhihe Li <[email protected]>
ZedLi
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the aria-description to the Edit form button in the Edit user details form
✅ Closes: FE-112
Description
🎟️ FE-112
Screenshots (if appropriate)
How to Test
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.