Icu 15181 add pagination to session recordings #2502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ui/admin/app/templates/scopes/scope/session-recordings/index.hbs
Outdated
Show resolved
Hide resolved
ZedLi
reviewed
Sep 30, 2024
ui/admin/app/controllers/scopes/scope/session-recordings/index.js
Outdated
Show resolved
Hide resolved
ui/admin/app/controllers/scopes/scope/session-recordings/index.js
Outdated
Show resolved
Hide resolved
ui/admin/app/controllers/scopes/scope/session-recordings/index.js
Outdated
Show resolved
Hide resolved
lisbet-alvarez
approved these changes
Oct 1, 2024
cameronperera
deleted the
ICU-15181-add-pagination-to-session-recordings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds pagination support for Session Recordings along with search for
session-recording.idand filters for user and target.Another change that is made in this PR is how we handle redirects for the
scopes.scope.session-recordings.session-recording.channels-by-connection.channelroute. If the user has entered a URL where the session recording ID is wrong, we redirect the user back to the list view and display a toast message.🎟️ Jira ticket
Screenshots (if appropriate)
Search and filter:
Screen.Recording.2024-09-27.at.2.12.34.PM.mov
Redirect change:
Screen.Recording.2024-09-25.at.12.19.34.PM.mov
How to Test
Create sessions with targets that have recording enabled. After creating a few, you should see the table of session recordings with new filters above.
Checklist