Skip to content

Conversation

@wongtonyb
Copy link
Collaborator

@wongtonyb wongtonyb commented Dec 22, 2025

Description

There's a conflict in the tests when looking for the Save button when the Project Name happens to include the word 'Save' in it.

// Updating Selector

// old
await this.page.getByRole('button', { name: 'Save' }).click();

// new
await this.page.getByRole('button', { name: 'Save', exact: true }).click();

https://hashicorp.atlassian.net/browse/ICU-18231

Screenshots (if appropriate)

How to Test

  1. boundary: enos scenario launch e2e_ui_aws builder:local
  2. boundary: bash scripts/test_e2e_env.sh -> copy scenario e2e variable outputs
  3. paste into terminal of boundary-ui
  4. pnpm admin:ce:aws

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@wongtonyb wongtonyb requested a review from a team December 22, 2025 21:03
@wongtonyb wongtonyb requested a review from a team as a code owner December 22, 2025 21:03
@vercel
Copy link

vercel bot commented Dec 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
boundary-ui Ready Ready Preview, Comment Dec 23, 2025 5:16pm
boundary-ui-desktop Ready Ready Preview, Comment Dec 23, 2025 5:16pm

@wongtonyb wongtonyb force-pushed the wongtonyb-e2e-selector-fix branch from b1cab98 to bb9f051 Compare December 23, 2025 17:15
@wongtonyb wongtonyb merged commit 4170c7a into main Dec 23, 2025
14 of 15 checks passed
@wongtonyb wongtonyb deleted the wongtonyb-e2e-selector-fix branch December 23, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants