Skip to content

Commit b1cab98

Browse files
wongtonybwongtonyb
committed
fix: 🐛 e2e - fix save button selector
1 parent 824427b commit b1cab98

File tree

13 files changed

+32
-32
lines changed

13 files changed

+32
-32
lines changed

‎e2e-tests/admin/pages/aliases.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export class AliasesPage extends BaseResourcePage {
3636
await this.page.getByLabel('Alias Value').fill(alias);
3737
await this.page.getByLabel('Target ID').fill(targetId);
3838

39-
await this.page.getByRole('button', { name: 'Save' }).click();
39+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
4040
await this.dismissSuccessAlert();
4141
await expect(
4242
this.page

‎e2e-tests/admin/pages/auth-methods.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class AuthMethodsPage extends BaseResourcePage {
2222
await this.page.getByRole('button', { name: 'New' }).click();
2323
await this.page.getByText('Password', { exact: true }).click();
2424
await this.page.getByLabel('Name').fill(authMethodName);
25-
await this.page.getByRole('button', { name: 'Save' }).click();
25+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
2626
await this.dismissSuccessAlert();
2727
await expect(
2828
this.page
@@ -113,7 +113,7 @@ export class AuthMethodsPage extends BaseResourcePage {
113113
await this.page.getByLabel('Maximum Age').fill('20');
114114
await this.page.getByLabel('API URL Prefix').fill(boundaryAddr);
115115

116-
await this.page.getByRole('button', { name: 'Save' }).click();
116+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
117117
await this.dismissSuccessAlert();
118118
await expect(
119119
this.page
@@ -166,7 +166,7 @@ export class AuthMethodsPage extends BaseResourcePage {
166166
await this.page.getByLabel('Name (Optional)').fill(accountName);
167167
await this.page.getByLabel('Login Name').fill(login);
168168
await this.page.getByLabel('Password', { exact: true }).fill(password);
169-
await this.page.getByRole('button', { name: 'Save' }).click();
169+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
170170
await this.dismissSuccessAlert();
171171
await expect(
172172
this.page
@@ -184,7 +184,7 @@ export class AuthMethodsPage extends BaseResourcePage {
184184
async setPasswordToAccount(password) {
185185
await this.page.getByRole('link', { name: 'Set Password' }).click();
186186
await this.page.getByLabel(new RegExp('Password*')).fill(password);
187-
await this.page.getByRole('button', { name: 'Save' }).click();
187+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
188188
await this.dismissSuccessAlert();
189189
}
190190
}

‎e2e-tests/admin/pages/credential-stores.js‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class CredentialStoresPage extends BaseResourcePage {
2727
.getByRole('group', { name: 'Type' })
2828
.getByLabel('Static')
2929
.click();
30-
await this.page.getByRole('button', { name: 'Save' }).click();
30+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
3131
await this.dismissSuccessAlert();
3232
await expect(
3333
this.page
@@ -59,7 +59,7 @@ export class CredentialStoresPage extends BaseResourcePage {
5959
.click();
6060
await this.page.getByLabel('Address').fill(vaultAddr);
6161
await this.page.getByLabel('Token').fill(clientToken);
62-
await this.page.getByRole('button', { name: 'Save' }).click();
62+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
6363
await this.dismissSuccessAlert();
6464
await expect(
6565
this.page
@@ -100,7 +100,7 @@ export class CredentialStoresPage extends BaseResourcePage {
100100
.getByRole('textbox')
101101
.fill(workerFilter);
102102
await this.page.getByLabel('Token').fill(clientToken);
103-
await this.page.getByRole('button', { name: 'Save' }).click();
103+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
104104
await this.dismissSuccessAlert();
105105
await expect(
106106
this.page
@@ -160,7 +160,7 @@ export class CredentialStoresPage extends BaseResourcePage {
160160
encoding: 'utf-8',
161161
});
162162
await this.page.getByLabel('SSH Private Key').fill(keyData);
163-
await this.page.getByRole('button', { name: 'Save' }).click();
163+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
164164
await this.dismissSuccessAlert();
165165
await expect(
166166
this.page
@@ -219,7 +219,7 @@ export class CredentialStoresPage extends BaseResourcePage {
219219
await this.page
220220
.getByLabel('Password Required', { exact: true })
221221
.fill(password);
222-
await this.page.getByRole('button', { name: 'Save' }).click();
222+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
223223
await this.dismissSuccessAlert();
224224
await expect(
225225
this.page
@@ -284,7 +284,7 @@ export class CredentialStoresPage extends BaseResourcePage {
284284
.getByLabel('Password Required', { exact: true })
285285
.fill(password);
286286
await this.page.getByLabel('Domain Required', { exact: true }).fill(domain);
287-
await this.page.getByRole('button', { name: 'Save' }).click();
287+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
288288
await this.dismissSuccessAlert();
289289
await expect(
290290
this.page
@@ -323,7 +323,7 @@ export class CredentialStoresPage extends BaseResourcePage {
323323
.selectOption(credentialType);
324324
}
325325

326-
await this.page.getByRole('button', { name: 'Save' }).click();
326+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
327327
await this.dismissSuccessAlert();
328328

329329
return credentialLibraryName;
@@ -364,7 +364,7 @@ export class CredentialStoresPage extends BaseResourcePage {
364364
.getByRole('button', { name: 'Add' })
365365
.click();
366366

367-
await this.page.getByRole('button', { name: 'Save' }).click();
367+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
368368
await this.dismissSuccessAlert();
369369

370370
return credentialLibraryName;

‎e2e-tests/admin/pages/groups.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export class GroupsPage extends BaseResourcePage {
2121
.click();
2222
await this.page.getByRole('link', { name: 'New', exact: true }).click();
2323
await this.page.getByLabel('Name').fill(groupName);
24-
await this.page.getByRole('button', { name: 'Save' }).click();
24+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
2525
await this.dismissSuccessAlert();
2626
await expect(
2727
this.page

‎e2e-tests/admin/pages/host-catalogs.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class HostCatalogsPage extends BaseResourcePage {
4040
.getByRole('group', { name: 'Type', exact: 'true' })
4141
.getByLabel('Static')
4242
.click();
43-
await this.page.getByRole('button', { name: 'Save' }).click();
43+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
4444
await this.dismissSuccessAlert();
4545
await expect(
4646
this.page
@@ -76,7 +76,7 @@ export class HostCatalogsPage extends BaseResourcePage {
7676

7777
await this.page.getByLabel('Name').fill(hostSetName);
7878
await this.page.getByLabel('Description').fill('This is an automated test');
79-
await this.page.getByRole('button', { name: 'Save' }).click();
79+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
8080
await this.dismissSuccessAlert();
8181
await expect(
8282
this.page
@@ -99,7 +99,7 @@ export class HostCatalogsPage extends BaseResourcePage {
9999
await this.page.getByLabel('Name').fill(hostName);
100100
await this.page.getByLabel('Description').fill('This is an automated test');
101101
await this.page.getByLabel('Address').fill(address);
102-
await this.page.getByRole('button', { name: 'Save' }).click();
102+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
103103
await this.dismissSuccessAlert();
104104
await expect(this.page.getByRole('link', { name: hostName })).toBeVisible();
105105

‎e2e-tests/admin/pages/orgs.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class OrgsPage extends BaseResourcePage {
2222
await this.page.getByRole('link', { name: 'New Org' }).click();
2323
await this.page.getByLabel('Name').fill(orgName);
2424
await this.page.getByLabel('Description').fill('This is an automated test');
25-
await this.page.getByRole('button', { name: 'Save' }).click();
25+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
2626
await this.dismissSuccessAlert();
2727
await expect(
2828
this.page
@@ -45,7 +45,7 @@ export class OrgsPage extends BaseResourcePage {
4545
await this.page
4646
.getByLabel('Storage Policy')
4747
.selectOption({ label: policyName });
48-
await this.page.getByRole('button', { name: 'Save' }).click();
48+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
4949
await this.dismissSuccessAlert();
5050
await expect(
5151
this.page.getByRole('listitem').getByText(policyName),

‎e2e-tests/admin/pages/projects.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class ProjectsPage extends BaseResourcePage {
2222
await this.page.getByRole('link', { name: 'New', exact: true }).click();
2323
await this.page.getByLabel('Name').fill(projectName);
2424
await this.page.getByLabel('Description').fill('This is an automated test');
25-
await this.page.getByRole('button', { name: 'Save' }).click();
25+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
2626
await this.dismissSuccessAlert();
2727
await expect(
2828
this.page

‎e2e-tests/admin/pages/roles.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export class RolesPage extends BaseResourcePage {
2626
.click();
2727
await this.page.getByRole('link', { name: 'New Role' }).click();
2828
await this.page.getByLabel('Name').fill(roleName);
29-
await this.page.getByRole('button', { name: 'Save' }).click();
29+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
3030
await this.dismissSuccessAlert();
3131
await expect(
3232
this.page

‎e2e-tests/admin/pages/storage-buckets.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export class StorageBucketsPage extends BaseResourcePage {
4949
.getByRole('textbox')
5050
.fill(workerFilter);
5151
await this.page.getByLabel('Disable credential rotation').click();
52-
await this.page.getByRole('button', { name: 'Save' }).click();
52+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
5353
await this.dismissSuccessAlert();
5454
await expect(
5555
this.page
@@ -103,7 +103,7 @@ export class StorageBucketsPage extends BaseResourcePage {
103103
.getByRole('textbox')
104104
.fill(workerFilter);
105105
await this.page.getByLabel('Disable credential rotation').click();
106-
await this.page.getByRole('button', { name: 'Save' }).click();
106+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
107107
await this.dismissSuccessAlert();
108108
await expect(
109109
this.page

‎e2e-tests/admin/pages/storage-policies.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export class StoragePoliciesPage extends BaseResourcePage {
4141
await this.page
4242
.getByLabel('Retention Policy')
4343
.selectOption({ label: 'Forever' });
44-
await this.page.getByRole('button', { name: 'Save' }).click();
44+
await this.page.getByRole('button', { name: 'Save', exact: true }).click();
4545
await this.dismissSuccessAlert();
4646
await expect(
4747
this.page

0 commit comments

Comments
 (0)