Skip to content

Conversation

djamg
Copy link
Contributor

@djamg djamg commented Oct 10, 2023

No description provided.

@djamg djamg requested review from vidya-ram and jace October 10, 2023 08:29
Copy link
Member

@jace jace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we even have this client-side regex? It's fragile and needs multiple test cases.

@djamg djamg requested a review from jace October 17, 2023 19:29
vidya-ram
vidya-ram previously approved these changes Oct 25, 2023
Copy link
Member

@jace jace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This regex is getting too complex and should be replaced with a URL parser. At the very least, it needs test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants