Add eslint configuration #1014
Merged
Add eslint configuration #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nargonath
force-pushed
the
add-eslint-config
branch
from
f85cb80 to
ff188b1
Compare
Nargonath
force-pushed
the
add-eslint-config
branch
from
ff188b1 to
cb2aabe
Compare
|
Tested on VSCode and it works:
|
|
@Nargonath amazing, thank you! This is a great enhancement to the DX of working on hapi for all contributors :) |
|
Yes, thank you @devinivy. I had enough manual formatting and decided to add the configuration. 😁 @lloydbenson will probably do some magic with some scripts to add it to the rest of the org. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to test that the configuration is correctly picked up by your IDE make sure to update your local dependencies to pick up the latest version of
@hapi/eslint-pluginotherwise you might not have the new configuration in it.