Mb share jpa date tests #3154
Merged
Mb share jpa date tests #3154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Share a date search tests between JPA and Mongo.
Codecov Report
@@ Coverage Diff @@
## master #3154 +/- ##
=========================================
Coverage 82.76% 82.77%
- Complexity 20057 20058 +1
=========================================
Files 1346 1346
Lines 72213 72213
Branches 10885 10885
=========================================
+ Hits 59769 59774 +5
+ Misses 8270 8264 -6
- Partials 4174 4175 +1
Continue to review full report at Codecov.
|
katiesmilecdr
approved these changes
Nov 10, 2021
tadgh
approved these changes
Nov 10, 2021
...ir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/search/ExtendedLuceneIndexExtractor.java
Outdated
Show resolved
Hide resolved
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>test-jar</goal> |
There was a problem hiding this comment.
what is this doing exactly?
There was a problem hiding this comment.
Builds a jar of all the test classes and publishes it as a test-jar type jar.
The alternative is another full project called something like hapi-fhir-storage-test-utils, but that seemed overkill for a couple of classes.
| @@ -2913,7 +2913,7 @@ | |||
| <profile> | |||
| <id>FASTINSTALL</id> | |||
| <properties> | |||
| <maven.test.skip>true</maven.test.skip> | |||
| <skipTests>true</skipTests> | |||
There was a problem hiding this comment.
just verifying you tested this and it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share the new date tests with Mongo.