[cmake] Fix and reorganize warnings for building Halide #5885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexreinking
commented
Apr 7, 2021
alexreinking
commented
- Group warnings by compiler / enable / disable / language (ie. C/C++-only)
- Remove two duplicated warning-disables for MSVC
- Remove Clang-only warning-disables from GCC, introduced by Improve ClangCL support by disabling, fixing warnings #5876
alexreinking
added
build
steven-johnson
approved these changes
Apr 7, 2021
alexreinking
removed
the
skip_buildbots
frengels
pushed a commit
to frengels/Halide
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.