Skip to content

Add explicit cast to remove ambiguous operator== (Fixes #5329) #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2021
Merged

Add explicit cast to remove ambiguous operator== (Fixes #5329) #5879

merged 1 commit into from
Apr 6, 2021

Conversation

abadams
Copy link
Member

@abadams abadams commented Apr 5, 2021

No description provided.

steven-johnson
steven-johnson approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cast looks really weird and unnecessary without comment, not sure if worth adding something terse

@abadams
Copy link
Member Author

abadams commented Apr 5, 2021

How so? e.type is a Halide::Type, and type is a halide_type_t

@steven-johnson
Copy link
Contributor

How so? e.type is a Halide::Type, and type is a halide_type_t

Ah, ok, I thought they were both halide_type_t

@steven-johnson
Copy link
Contributor

Failures are unrelated (error in nightly LLVM13), ok to land

@abadams abadams merged commit 85816e4 into master Apr 6, 2021
@alexreinking alexreinking added this to the v12.0.0 milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v12.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@abadams @steven-johnson @alexreinking