-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Improve ClangCL support by disabling, fixing warnings #5876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5aad444
a7d4e8c
014afc3
cf946dd
41e8bf8
f7ddd48
4265af5
b19a7b3
3a60c98
b502cae
808c1e7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -283,8 +283,6 @@ class SloppyUnpredicateLoadsAndStores : public IRMutator { | |
|
||
return Call::make(op->type, Call::if_then_else, | ||
{condition, load, make_zero(op->type)}, Call::Intrinsic); | ||
|
||
return load; | ||
Comment on lines
-286
to
-287
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ouch. I wonder if this was a bad merge. Probably worth turning on this warning explicitly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yow. I'm genuinely surprised this is merely a warning. |
||
} else { | ||
// It's a predicated vector gather. Just scalarize. We'd | ||
// prefer to keep it in a loop, but that would require | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,7 +71,7 @@ struct IntrusivePtr { | |
if (p) { | ||
ref_count(p).increment(); | ||
} | ||
}; | ||
} | ||
|
||
void decref(T *p) { | ||
if (p) { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -571,7 +571,7 @@ class LowerWarpShuffles : public IRMutator { | |
|
||
Expr wild = Variable::make(Int(32), "*"); | ||
vector<Expr> result; | ||
int bits; | ||
int bits = 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The reason this isn't needed is extremely subtle: the function There's no downside to this (this is not performance-critical) and disabling uninitialized use warnings seems significantly worse. |
||
|
||
// Move this_lane as far left as possible in the expression to | ||
// reduce the number of cases to check below. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, I'd actually love to enable whatever warnings complains about this, it's a minor pet peeve of mine