Code changes

[Jonnyw2k]

const int RC_MAX_WIDTH = 1550; //absolute max: 2003; //max microseconds
const int RC_COMMS_TIMEOUT = 2000; // Time since last command

Timeout is less than absolute max value.

Also line 172 is not in consistent style as rest of if statements

[robberwick]

Excellent points, and beautifully volunteered. I've assigned this issue to you Jonny - Feel free to make the changes and submit a pull request :-)

[markmellors]

The time-out of 2000 is in milliseconds, the RC pulses are 2000 microseconds. The time out started off at a sensible 200 milliseconds but I changed it to 2000 (i.e. 2 seconds) whilst we were debugging. I think it should be changed back to 200 milliseconds, I don't think bighak should carry on for 2 seconds if it stops receiving commands.
I need to improve the comments a little, as the max width meaning is unclear too. The full range of the input signal is ~986-2003, but we consider it to be full speed if its below 1350 or above 1550.

[Jonnyw2k]

I kind of thought that's what it was but wasn't 100% sure

On Monday, 8 September 2014, markmellors notifications@github.com wrote:

The time-out of 2000 is in milliseconds, the RC pulses are 2000
microseconds. The time out started off at a sensible 200 milliseconds
but I changed it to 2000 (i.e. 2 seconds) whilst we were debugging. I think
it should be changed back to 200 milliseconds, I don't think bighak should
carry on for 2 seconds if it stops receiving commands.
I need to improve the comments a little, as the max width meaning is
unclear too. The full range of the input signal is ~986-2003, but we
consider it to be full speed if its below 1350 or above 1550.

—
Reply to this email directly or view it on GitHub
#3 (comment)
.

[robberwick]

Can you revert that commit, Jonny?
On 8 Sep 2014 11:18, "Jonnyw2k" notifications@github.com wrote:

I kind of thought that's what it was but wasn't 100% sure

On Monday, 8 September 2014, markmellors notifications@github.com
wrote:

The time-out of 2000 is in milliseconds, the RC pulses are 2000
microseconds. The time out started off at a sensible 200 milliseconds
but I changed it to 2000 (i.e. 2 seconds) whilst we were debugging. I
think
it should be changed back to 200 milliseconds, I don't think bighak
should
carry on for 2 seconds if it stops receiving commands.
I need to improve the comments a little, as the max width meaning is
unclear too. The full range of the input signal is ~986-2003, but we
consider it to be full speed if its below 1350 or above 1550.

—
Reply to this email directly or view it on GitHub
<
https://github.com/hackhitchin/bighak-arduino/issues/3#issuecomment-54798435>

.

—
Reply to this email directly or view it on GitHub
#3 (comment)
.

[Jonnyw2k]

No, as in according to google reverting a commit can break things and I should just change it back and issue a new pull requested.

[Jonnyw2k]

I could "git push -f origin HEAD^:master "