Skip to content

Conversation

Patdabaker
Copy link
Member

@Patdabaker Patdabaker commented Jul 10, 2025

Fixes #7239

What changes did you make?

  • Added a github handle for Bryanna Lim

Why did you make the changes (we will use this info to test)?

  • To prepare for the eventual replacement of github and picture variables in the project file

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • Added an empty github handle variable to project file. No visual changes to the website

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Patdabaker-add-github-handle-7239 gh-pages
git pull https://github.com/Patdabaker/website.git add-github-handle-7239

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jul 10, 2025
@t-will-gillis t-will-gillis self-requested a review July 13, 2025 17:44
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Patdabaker - Great job!

  • branches from and to are good
  • the orig. issue is linked
  • there are concise and appropriate responses to what was changed and why
  • the PR was checked for CodeQL alerts
  • there are no visual changes

Everything looks good- thanks for contributing!

Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Patdabaker !
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Changes appear correctly on the site. Github handle has been added.
  • Relevant images were included to show visual changes
  • A note was included that there were no visual changes
  • The PR request clearly states what was updated
  • The PR request states why the changes are being made

Again, nice work and thanks for taking the time to contribute to the website!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Jul 17, 2025
@LRenDO LRenDO merged commit 81ec81f into hackforla:gh-pages Jul 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Bryanna Lim in tech-work-experience.md REVISED
3 participants