Skip to content

Conversation

Monomer9
Copy link
Member

Fixes #8004

What changes did you make?

  • Removed Samantha Hyler from Leadership variable
  • Saved changes to expunge-assist.md

Why did you make the changes (we will use this info to test)?

  • To keep the leadership for Expunge Assist tool up to date on the website

Screenshots of Proposed Changes Of The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

assist-expunge-before

Visuals after changes are applied

assist-expunge-after

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Monomer9-update-project-profile-expunge-assist-8004 gh-pages
git pull https://github.com/Monomer9/website.git update-project-profile-expunge-assist-8004

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 21, 2025
@caz002 caz002 self-requested a review June 21, 2025 21:58
@caz002
Copy link
Member

caz002 commented Jun 21, 2025

Review ETA: end of day(6/21/25)
Availability: after 2pm most days

@caz002
Copy link
Member

caz002 commented Jun 21, 2025

I need some help with creating a new branch to review the changes. I am getting a message that my branch has a merge conflict/divergent changes I try to run git pull https://github.com/Monomer9/website.git update-project-profile-expunge-assist-8004. To try to solve the issue, I tried running git pull and git pull upstream gh-pages, as well as updating my fork of the website with the main repository, but I am still getting the message. Screenshot 2025-06-21 at 3 16 25 PM

@kdaca19xx
Copy link
Member

Availability: after 1pm (pacific)
ETA: 6/25

@t-will-gillis
Copy link
Member

Hey @caz002 saw your note about the divergent branches. Feel free to send me a message on Slack

@xnealcarson
Copy link
Member

Availablity: After 5pm PST
ETA: 6/25 end of day

Copy link
Member

@caz002 caz002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue @Monomer9!

The only change I can see to make is to check the box at the end of the review indicating that you found no CodeQL alerts. Otherwise, the pull request looks good.

Things done well:

  • Changes and the reasoning for making them is explained clearly
  • Branch only changes the code/files requested by the issue
  • Visuals of the website clearly indicate changes

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Jun 25, 2025
Copy link
Member

@xnealcarson xnealcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Monomer9. Many thanks for working on this issue!

Things Done Well

  • The issue has the correct 'commit into'.
  • the 'commit from' and 'collaborator' names match.
  • The linked issue is present.
  • The changes made are applicable and clean.
  • Changes were viewable in browser.

Suggested Changes

  • I have none to make besides the unchecked Code QL box that @caz002 mentions in their review. Once you've checked that box, I'll go ahead and approve this PR.

Otherwise, fantastic job completing this issue!

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to go, Monomer9!

Things Done Well

  • The pull request done with the correct branch.

  • There's a linked issue, and I understood it.

  • I appreciate you adding the file name under "What changes did you make?" for easy reference.

  • The changes in the Files Changed tab look good.

Suggestions

  • Ditto on what caz002 suggested about checking the correct box under the "QR Code alerts" section.

@mugdhchauhan
Copy link
Member

Hey @Monomer9, this PR is almost complete but please could you make the changes the reviewers have suggested and provide an ETA for when you are planning to complete this. Thanks.

@myronchen-git
Copy link
Member

Monomer9 is no longer active. Should we just approve it? Everything is done and there are no issues.

@mugdhchauhan
Copy link
Member

mugdhchauhan commented Aug 24, 2025

As discussed in today's meeting, I'm closing this PR as the original dev is inactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist- Remove Samantha Hyler
7 participants