-
-
Notifications
You must be signed in to change notification settings - Fork 841
Removed Samantha Hyler and information about them from the leadership #8199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Samantha Hyler and information about them from the leadership #8199
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: end of day(6/21/25) |
Availability: after 1pm (pacific) |
Hey @caz002 saw your note about the divergent branches. Feel free to send me a message on Slack |
Availablity: After 5pm PST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this issue @Monomer9!
The only change I can see to make is to check the box at the end of the review indicating that you found no CodeQL alerts. Otherwise, the pull request looks good.
Things done well:
- Changes and the reasoning for making them is explained clearly
- Branch only changes the code/files requested by the issue
- Visuals of the website clearly indicate changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Monomer9. Many thanks for working on this issue!
Things Done Well
- The issue has the correct 'commit into'.
- the 'commit from' and 'collaborator' names match.
- The linked issue is present.
- The changes made are applicable and clean.
- Changes were viewable in browser.
Suggested Changes
- I have none to make besides the unchecked Code QL box that @caz002 mentions in their review. Once you've checked that box, I'll go ahead and approve this PR.
Otherwise, fantastic job completing this issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way to go, Monomer9!
Things Done Well
-
The pull request done with the correct branch.
-
There's a linked issue, and I understood it.
-
I appreciate you adding the file name under "What changes did you make?" for easy reference.
-
The changes in the Files Changed tab look good.
Suggestions
- Ditto on what caz002 suggested about checking the correct box under the "QR Code alerts" section.
Hey @Monomer9, this PR is almost complete but please could you make the changes the reviewers have suggested and provide an ETA for when you are planning to complete this. Thanks. |
Monomer9 is no longer active. Should we just approve it? Everything is done and there are no issues. |
As discussed in today's meeting, I'm closing this PR as the original dev is inactive. |
Fixes #8004
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging