generated from hackforla/.github-hackforla-base-repo-template
-
-
Notifications
You must be signed in to change notification settings - Fork 27
Labels
P3: MedMedium priorityMedium priorityPBV: devall issues for engineering roles (devops, backend, frontend, db)all issues for engineering roles (devops, backend, frontend, db)complexity: largefeature: Quality ControljavascriptPull requests that update Javascript codePull requests that update Javascript coderole: frontendPertains to frontend tasksPertains to frontend taskssize: 8ptCan be done in 31-48 hoursCan be done in 31-48 hours
Milestone
Description
Story
As a developers, we should have reliable unit tests for the frontend so that we can detect bugs early and ensure that new changes don't introduce unintended consequences.
Overview
We recently migrated from CRA+Webpack to Vite, which means that our old unit tests in Jest will no longer be effective. Vite does not have out of box support for Jest. We should migrate our Jest unit tests to Vitest.
Lastly, some old unit tests are outdated because they tested old Design System UI components. We need to audit them to see if they are still relevant for testing updated UI components.
- For example, this PR about Checkbox component introduces a totally new tailwind Checkbox, but does not update the old jest tests for the old sass Checkbox, so they may fail when trying to test it.
Action Items
- Migrate all Jest unit tests to Vitest
- Audit old unit tests with updated tailwind UI components
- Make sure
npm run test
is fully functional - Write documentation about how frontend unit tests work on our app
Resources
- Resources
- TDM Calculator Vitest migration: Bug: Client-Side Unit Tests are Broken tdm-calculator#2282
- 311 Data Vitest migration: add basic frontend tests with Vitest + React Testing Library 311-data#1873
Metadata
Metadata
Assignees
Labels
P3: MedMedium priorityMedium priorityPBV: devall issues for engineering roles (devops, backend, frontend, db)all issues for engineering roles (devops, backend, frontend, db)complexity: largefeature: Quality ControljavascriptPull requests that update Javascript codePull requests that update Javascript coderole: frontendPertains to frontend tasksPertains to frontend taskssize: 8ptCan be done in 31-48 hoursCan be done in 31-48 hours
Type
Projects
Status
📋 Prioritized Backlog