fix(v1): preserve encoded req.url for proxied requests#1356
Closed
guoyangzhen wants to merge 1 commit intoh3js:v1from
Closed
fix(v1): preserve encoded req.url for proxied requests#1356guoyangzhen wants to merge 1 commit intoh3js:v1from
guoyangzhen wants to merge 1 commit intoh3js:v1from
Conversation
When a request arrives with percent-encoded characters (e.g., /api/%C3%A9), h3 v1.15.7+ decodes the path for internal routing but also overwrites with the decoded result. This breaks HTTP proxies (like Nitro's dev server using httpxy) because they forward the decoded raw UTF-8 characters instead of the percent-encoded form, causing 400 Bad Request from downstream. This fix: - Preserves the original encoded for the common case (no prefix) - For mounted sub-apps with route prefix, strips prefix from the encoded URL (not the decoded one) - Decoded path is still used for internal route matching (security fix preserved)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
fixed by #1355 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1354
Problem
Since v1.15.7,
createAppEventHandlerdecodes percent-encoded URL paths and writes the decoded result back toevent.node.req.url. This causes HTTP proxies (like Nitro's dev server usinghttpxy) to forward requests with raw UTF-8 characters instead of percent-encoded form, resulting in 400 Bad Request from downstream servers.Example:
Root cause
_decodePathdecodes%C3%A9 → é, then line 174 (event.node.req.url = _layerPath) overwritesreq.urlwith the decoded path.Fix
req.urlbefore any modificationsreq.urlunchangedKey changes
_originalReqUrlto preserve the incoming encoded URLevent.node.req.url = _layerPath(the decoded assignment)event._path(used byevent.pathgetter) still uses decoded path for correct route matching