Fix console log uses debug #10139
Open
Fix console log uses debug #10139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…og (inspector info level) in ConsoleLogHandler
…og (inspector info level) in ConsoleLogHandler
|
I beg your pardon, this is my first attempt to publish a patch |
jnehlmeier
requested changes
Jul 5, 2025
| @@ -77,7 +77,9 @@ private native void info(String message) /*-{ | |||
| window.console.info(message); | |||
| }-*/; | |||
|
|
|||
| private native void log(String message) /*-{ | |||
| window.console.log(message); | |||
| private native void logVerbose(String message) /*-{ | |||
There was a problem hiding this comment.
Please rename the method to debug to match the naming scheme of all the other logging methods. Also the comment can be removed as it is already pretty clear what is going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates ConsoleLogHandler to use console.debug() instead of console.log() for log levels FINE, FINER, and FINEST, ensuring that these messages are only shown in the "Verbose" tab in browser developer tools. This aligns with standard browser behavior for log levels.