Super dev mode for version 2.10.0 is disabled and radio button is hidden #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mode to support gwt 2.10.
|
Hi @protoism Thank you for your fast reply, yes i tested it with eclipse and let me know if i should do anything from my side. |
|
The PR is quite simple and reasonable. |
protoism
approved these changes
Mar 2, 2023
| @@ -744,7 +744,7 @@ protected void updateLaunchConfigurationDialog() { | |||
| * @return true if super dev mode can be used | |||
| */ | |||
| private boolean canSdkVersionUseSuperDevMode(String version) { | |||
| return version.matches("^2.[5-9].*") || version.matches("^[3-9].*"); | |||
| return version.matches("^2.([5-9]|1\\d).*") || version.matches("^[3-9].*"); | |||
Contribute more :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing GWT SDK 2.10.0, I found that radio button group that allows to choose between super development mode and legacy developement mode in the GWT debugging configuration is hidden and argument -nosuperdevmode is forced.
I found that the pattern that decide whether the GWT version supports super dev mode or not excludes 2.10.0.
I know that 2.10.0 still not supported by current plugin but as you see as the code support versions [3-9].* it should also support 2.10.0 version.