Skip to content

Removed option for history frame from new host page wizard #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

protoism
Copy link
Contributor

@protoism protoism commented Feb 16, 2023

Even though there's an option to disable the GWT history frame, there's no such corresponding option for the new project wizard, so I removed the option and the logic altogether.

Fixes #443

@niloc132
Copy link
Member

Thoughts on deferring this to 4.1, since while certainly modern versions of GWT don't need/support it, old ones might...

@protoism
Copy link
Contributor Author

@niloc132 ok to move to 4.1

@niloc132 niloc132 added this to the 4.1 milestone Feb 16, 2023
@protoism
Copy link
Contributor Author

Just to clarify,
the "new GWT Application" wizard does not add a __gwt_historyFrame to the html page, while the "new Host Page" does.
There's probably no problem whatsoever with old GWT SDKs

@protoism protoism merged commit 6eb36ed into gwt-plugins:main Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove __gwt_historyFrame from generated project
2 participants