Merged
Conversation
Add method `nlmod.grid.gdf_area_per_index_to_da' Replace `"angrot" in ds.attrs and ds.attrs["angrot"] != 0.0` by `is_rotated(ds_out)` in `nlmod.grid` Add docstring to `nlmod.time.dataframe_to_flopy_timeseries` Add `nlmod.plot.get_ahn_colormap` Add parameter `season_filename` to `nlmod.gwf.surface_water.gdf_to_seasonal_pkg`
dbrakenhoff
approved these changes
Jun 25, 2025
Collaborator
dbrakenhoff
left a comment
dbrakenhoff
left a comment
There was a problem hiding this comment.
Nice, good additions :)
Collaborator
|
Ah, just saw your comment about the names, some suggestions: gdf_area_per_index_to_da
move_index_from_end_to_start
|
Collaborator
Author
|
After discussing with @dbrakenhoff : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple smaller changes:
nlmod.grid.gdf_area_per_index_to_da"angrot" in ds.attrs and ds.attrs["angrot"] != 0.0byis_rotated(ds_out)innlmod.gridnlmod.time.dataframe_to_flopy_timeseriesmove_index_from_end_to_starttonlmod.time.dataframe_to_flopy_timeseriesnlmod.plot.get_ahn_colormapseason_filenametonlmod.gwf.surface_water.gdf_to_seasonal_pkgNot sure about the naming of
gdf_area_per_index_to_daandmove_index_from_end_to_start. Suggestions are welcome...