Conversation
…ctor storage, and a simple GraphRAG example
|
Great Work and thank you! |
No access to Windows on my part, but it should work: Can confirm this works on M3 Mac and worked on Ubuntu 20.04. **Why don't we use docker containerization with |
…tter speed/recall tradeoffs
Cool! Few responses:
|
Sounds good!
*** I'm done with commits for this PR, let me know what you think 👍 |
|
Cool, I have only one review about this PR and maybe you can look at it. |
nano_graphrag/graphrag.py
Outdated
| global_config=asdict(self), | ||
| embedding_func=self.embedding_func, | ||
| meta_fields={"entity_name"}, | ||
| **self.vector_db_storage_cls_kwargs, |
There was a problem hiding this comment.
Why unpack vector_db_storage_cls_kwargs here?
You get this dict from global_config in HNSWStorage.
Unpack vector_db_storage_cls_kwargs here maybe break other vector storage's initialization.
* Updated storage with hnswlib, unittests, benchmarking against nano vector storage, and a simple GraphRAG example * Added kwargs for vector storage cls to pass on hyperparameters for better speed/recall tradeoffs * Removed redundant passing of in --------- Co-authored-by: terence-gpt <numberchiffre@users.noreply.github.com>

Description
TLDR; fast querying with slow insertion, using
hnswlibfaster than the HNSW fromfaissimplementation.Updates
HNSWVectorDBStorage.NanoVectorDBStorage.exampleswithGraphRAG(Easily triggering rate limit but unrelated to this PR).Benchmark results