Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous logic for truncation by length was too coarse-grained, failing to account for the extra characters used in various connections such as chat templates, templates, headers, and lists. Additionally, it did not consider the measurement discrepancies between different tokenizers (e.g., Qwen and GPT-4o can differ by up to 2k tokens in some cases). To address all these issues, we have proposed a preliminary solution.
We introduced a more refined, albeit more cumbersome, length budget allocation. At the same time, we allow users to pass a Hugging Face tokenizer via GraphRAG parameters to serve as the metric for token counting.
close #146