Re-run getimagesize without source_info if false #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain JPG images fail to get the $image_info variable when $this->source_info is set in the getimagesize function if the exif data is not what PHP is expecting. This ends up throwing exceptions instead of letting them through as though they do not have exif data. To allow valid images to make it through, we need to check to see if we can retreive $image_info via getimagesize WITH $this->source_info, if not (getimagesize returns FALSE), then get the $image_info without the $this->source_info. Then it will fall back to throwing the ImageResizeException if it still does not exist.
|
Why add composer.lock to gitignore? |
|
Because composer.lock should not be committed up in a library. That should be generated each time a new engineer runs |
|
@adityapatadia will you tag this, please? |
|
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain JPG images fail to get the $image_info variable when
$this->source_info is set in the getimagesize function if the exif data
is not what PHP is expecting. This ends up throwing exceptions instead
of letting them through as though they do not have exif data.
To allow valid images to make it through, we need to check to see if we
can retreive $image_info via getimagesize WITH $this->source_info, if
not (getimagesize returns FALSE), then get the $image_info without the
$this->source_info. Then it will fall back to throwing the
ImageResizeException if it still does not exist.