-
-
Notifications
You must be signed in to change notification settings - Fork 50
fix: Do not start and end the stream prematurely #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is awesome. Thanks for debugging and adding a regression test! I think we can actually leverage the |
UPDATE: I am dumb... forgot about the callback. |
f022a1c to
81552cc
Compare
|
Pushed new changes (switch to |
|
Any update on this? Is there anything else I can do? Ty. |
Would love to have this merged and released. If there is anything I can do to help that, let me know. |
yocontra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me, will let @phated weigh in here
950413f to
9011e7a
Compare
|
@pavelhoral Sorry for such a long delay—life kicked my butt last year. I want to say that your work here is greatly appreciated! You performed amazing debugging and the fix is great. I wanted to give this PR the attention it deserved, which lead me to finding the regression test didn't fail on main. I figured out that inserting a transform stream resulted in the failure, so I pushed that on the branch. I also rebased to get some CI fixes that I just landed. |
|
This has been released as v8.0.3 Again, sorry for the really long delay and thank you so much for the contribution! |
This PR fixes premature start of the glob stream which can lead to closing the resulting Transform stream before it is being properly processed by upstream components. This can lead to very strange race conditions and unfinished pipelines.
Closes #135