add repetition_penalty to SamplingParams#1302
Merged
JC1DA merged 3 commits intoguidance-ai:mainfrom Jul 3, 2025
Merged
Conversation
hudson-ai
reviewed
Jul 3, 2025
| assert np.all(transformers_logits == guidance_logits), "Logits do not match after min_p filtering" | ||
|
|
||
|
|
||
| def test_repetition_penalty_filtering(): |
Collaborator
There was a problem hiding this comment.
Could you parameterize this test to try a few different values of repetition penalty: <1, =1, >1?
(Note: not a bad idea to do something similar for the other params)
Collaborator
Author
There was a problem hiding this comment.
maybe in the next PR? I'll do for all previous tests at once.
hudson-ai
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.