Loop Video: interaction stories #14232
Merged
+87
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/loop-video-interaction-stories
branch
from
b241809 to
06ef1e2
Compare
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/loop-video-interaction-stories
branch
from
f35bca2 to
fcb3412
Compare
domlander
force-pushed
the
doml/loop-video-interaction-stories
branch
from
fcb3412 to
b2a7934
Compare
domlander
commented
Jul 17, 2025
| @@ -137,8 +137,8 @@ export const LoopVideoPlayer = forwardRef( | |||
| id={loopVideoId} | |||
| css={videoStyles(width, height)} | |||
| ref={ref} | |||
| role="button" | |||
There was a problem hiding this comment.
I initially added this as the video has click functionality - it pauses and plays the video. However, I think setting the role to button is more unhelpful than helpful to a user, given that the primary function of the video is not a button.
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
abeddow91
approved these changes
Jul 22, 2025
|
Seen on PROD (merged by @domlander 10 minutes and 31 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Add interaction stories for the Loop Video component.
Removes
role="button"from the video element.Why?
Increase test coverage.
Setting the role to button is more unhelpful than helpful to a user, given that the primary function of the video is not a button.