Skip to content

Add gallery to decide layout #14231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

marjisound
Copy link
Contributor

@marjisound marjisound commented Jul 16, 2025

What does this change?

This PR adds GalleryLayout to DecideLayoutWeb and DecideLayoutApps. Since GalleryLayout needs the Article type in it's props, the props for DecideLayout and also DecideLayoutApps and DecideLayoutWeb had to get updated to use the Article type rather than just frontendData (which is a field within the Article type).

This fixes #14183

@marjisound marjisound added the run_chromatic Runs chromatic when label is applied label Jul 16, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jul 16, 2025
@marjisound marjisound added the run_chromatic Runs chromatic when label is applied label Jul 16, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jul 16, 2025
@marjisound marjisound added the run_chromatic Runs chromatic when label is applied label Jul 16, 2025
@marjisound marjisound marked this pull request as ready for review July 16, 2025 16:05
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jul 16, 2025
@marjisound marjisound self-assigned this Jul 16, 2025
@deedeeh deedeeh changed the title Add galley to decide layout Add gallery to decide layout Jul 17, 2025
@marjisound marjisound requested review from JamieB-gu and a team July 21, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Gallery in DCAR article requests
1 participant