WIP - Enable visible recaptcha on all newsletters page #14213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into the AllEditorialNewslettersPage so we can toggle visible or invisible recaptcha on that page
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
7 tasks
| @@ -174,7 +174,10 @@ | |||
| }, | |||
| "googleRecaptchaSiteKey": { | |||
| "type": "string" | |||
| } | |||
| }, | |||
| "googleRecaptchaSiteKeyVisible": { | |||
There was a problem hiding this comment.
Did you run make gen-schemas ?
| @@ -78,6 +78,8 @@ export const renderEditorialNewslettersPage = ({ | |||
| abTests: newslettersPage.config.abTests, | |||
| brazeApiKey: newslettersPage.config.brazeApiKey, | |||
| googleRecaptchaSiteKey: newslettersPage.config.googleRecaptchaSiteKey, | |||
There was a problem hiding this comment.
This is now implicitly the invisible key. Do we want to do further refactoring ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
WIP!
AllEditorialNewslettersPageReactGoogleRecaptchaif thenewslettersPage.config.switches.manyNewsletterVisibleRecaptchafeature switch is enabled/frontend/dev/...and/frontend/code/...parameter storesWhy?
So we can toggle visible or invisible reCAPTCHA v2 on that page to test which performs better against bots.
Screenshots
<ManyNewslettersForm/>