Use Sourcepoint geolocation test #2145
Open
+267
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 146d4c9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
github-actions
bot
added
📦 npm
akinsola-guardian
changed the title
akinsola-guardian
added
the
🐥 Canaries
|
Note The following canaries were published to NPM: 🐥 |
akinsola-guardian
force-pushed
the
al-sp-geolocation-test
branch
from
61835bc to
0daab9e
Compare
|
Note The following canaries were published to NPM: 🐥 |
akinsola-guardian
force-pushed
the
al-sp-geolocation-test
branch
from
0daab9e to
c0ae5f0
Compare
|
Note The following canaries were published to NPM: 🐥 |
|
Note The following canaries were published to NPM: 🐥 |
|
Note The following canaries were published to NPM: 🐥 |
|
Note The following canaries were published to NPM: 🐥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
This PR is the first step for temporarily switching to Sourcepoint's geolocation. This change sits behind an ab-test which will be pointing to the Sourcepoint test environment by updating the config for user's opted in to the test. This ab-test allows the commercial team and stakeholders in Australia and United States to test potential impacts to advertising. To implement the ab-test, the
cmp.inittakes the booleanisInSourcepointGeolocationTest.To effectively switch to Sourcepoint's geolocation, we must:
For all users, the behaviour should continue to use our geolocation to determine the banner and vendor list interacted with.
For users opted in, this PR will:
To complete the switch to Sourcepoints geolocation we would:
Why?
Rollout plan
This is a redo of a previously rolled back commit: #2109