Skip to content

Adds eslint-plugin-react-hooks to eslint config #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

Adds eslint-plugin-react-hooks to eslint config #1749

merged 1 commit into from
Oct 28, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Oct 28, 2024 •
edited
Loading

What are you changing?

  • adds support for eslint-plugin-react-hooks in @guardian/eslint-config
  • bumps deps

Why?

@sndrs sndrs requested review from a team as code owners October 28, 2024 14:08
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 9510089

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Oct 28, 2024
@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/eslint-config labels Oct 28, 2024
@sndrs sndrs enabled auto-merge (squash) October 28, 2024 14:10
oliverabrahams
oliverabrahams approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sndrs sndrs merged commit 05b776e into main Oct 28, 2024
20 of 21 checks passed
@sndrs sndrs deleted the sndrs/eslint-bump branch October 28, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverabrahams oliverabrahams oliverabrahams approved these changes

Assignees
No one assigned
Labels
@guardian/eslint-config 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sndrs @oliverabrahams