Skip to content

Conversation

@aturzone
Copy link
Contributor

Previously, errors from zipWriter.Close() and gzWriter.Close() were silently ignored when using defer statements. This could result in corrupted archives being served to users if buffer flush or finalization failed.

Now explicitly checking Close() errors for all archive writers to ensure archives are properly finalized before being sent.

Description

According to the contributing guide, A PR should contain:

  • A clear description of why it was opened.
  • A short title that best describes the change.
  • Must pass unit and integration tests, which can be run checked locally prior to opening a PR.
  • Any additional details for functionality not covered by tests.

Additional Details

Previously, errors from zipWriter.Close() and gzWriter.Close()
were silently ignored when using defer statements. This could
result in corrupted archives being served to users if buffer
flush or finalization failed.

Now explicitly checking Close() errors for all archive writers
to ensure archives are properly finalized before being sent.
@gtsteffaniak
Copy link
Owner

seems like a good change -- lgtm

@gtsteffaniak gtsteffaniak merged commit 7e5a579 into gtsteffaniak:main Dec 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants