fix(http): handle Close() errors in archive creation #1745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, errors from zipWriter.Close() and gzWriter.Close() were silently ignored when using defer statements. This could result in corrupted archives being served to users if buffer flush or finalization failed.
Now explicitly checking Close() errors for all archive writers to ensure archives are properly finalized before being sent.
Description
According to the contributing guide, A PR should contain:
Additional Details