Move custom CSS and user-selected theme styles to the end of the body… #1744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for improved rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Custom CSS to End of
<body>for Correct Load OrderProblem
Custom CSS variables (
{{ .htmlVars.customCSS }}and{{ .htmlVars.userSelectedTheme }}) were loaded in the<head>. As a result, they could be overridden by bundled CSS loaded later via Vite’s module script.Solution
The custom CSS
<style>block was moved to the end of the<body>, after the Vite script tag. This guarantees that custom styles load last and take precedence without relying on!important.Changes
<head>style block<style>block at the end of<body>containing the custom CSS variablesBenefits
!importantin custom CSSThanks for taking the time to review the PR !