Skip to content

Conversation

@Kurami32
Copy link
Collaborator

@Kurami32 Kurami32 commented Dec 9, 2025

Description
I'm not sure if counts as improvement or fix, but this should accomplish 3 things:

  • In mobile, when in media mode, the navigation was being triggered 2 times, skipping 1 file in the queue each time that you pressed the buttons.

  • In mobile, long pressing the buttons was triggering navigation, making difficult to open the file list if you don't swipe fast. Now if you long press and if you don't move your finger, after release the tap will trigger navigation, but if you swipe a bit (but not enough to open the file list) will return the button to its position.

  • In desktop, if you dragged the buttons with the mouse but the drag was not enough to open the file list, was triggering navigation. Now just returns to its original position instead.

According to the contributing guide, A PR should contain:

  • A clear description of why it was opened.
  • A short title that best describes the change.
  • Must pass unit and integration tests, which can be run checked locally prior to opening a PR.
  • Any additional details for functionality not covered by tests.

Additional Details
Now fast-forward/rewind shortcuts in the media player should work fine, even if is paused 👍
Since before was checking if the media was playing to handle (or not) the arrow keys.

@Kurami32 Kurami32 changed the base branch from main to dev/v1.1.4 December 9, 2025 04:11
@Kurami32
Copy link
Collaborator Author

Kurami32 commented Dec 9, 2025

also noticed another thing... but not sure if is intended or is a bug (?).

Is related to the showParentDirectories method.

if (type === 'previous') {
// Show parent directories for navigating up
this.showParentDirectories();
} else if (type === 'next') {
// Show current listing items for quick jumping
this.showCurrentListing();
}
},
showParentDirectories() {
// Show files in the current directory (same directory as the previewed file)
const currentItems = this.getCurrentListingItems();
mutations.showHover({
name: "file-list",
props: {
fileList: currentItems,
mode: "navigate-siblings",
title: this.$t("prompts.quickJump")
}

Looks like is to list the sibling directories when opening file list from the previous (left) button, but I think that I've never saw that working.

We should fix it? or both buttons should do the same thing? Cuz right now opening the file list from both buttons (next and previous) open the same file listing.

@gtsteffaniak
Copy link
Owner

yeah great point thats definitely an issue, lets remove that condition in this PR too. just do showCurrentListing on both

@Kurami32
Copy link
Collaborator Author

And btw I tried to fix it (adding a type in file-listing) just to see how it looks and behave:

image

Clicking the directory just navigate to them, is like the breadcrumbs but in listing, is interesting but has some issues (like when there is not previous or next file, which is easy to fix I think).


Either way, I think that's fine to keep both with the same listing.

@gtsteffaniak
Copy link
Owner

I think the nextPrevious should only allow files not folders, can we add a simple filter for type != "directory" ?

@Kurami32
Copy link
Collaborator Author

Kurami32 commented Dec 10, 2025

I not added that to the PR (I was just testing and commenting how looks like if were fixed 😅)

I removed the condition like you said and both open the file listing, all is still behaving the same.

2025-12-10.15-13-55.mp4

@gtsteffaniak
Copy link
Owner

yep looks good now, thanks for finding that and fixing it :)

@gtsteffaniak gtsteffaniak merged commit 9255bc1 into dev/v1.1.4 Dec 10, 2025
17 checks passed
@Kurami32 Kurami32 deleted the fix-nextPrevious-behaviors branch December 10, 2025 22:40
@Kurami32
Copy link
Collaborator Author

Yeah, but was more a misunderstanding. I think that I should have worded the comment better... sorry for that.


Well, unrelated but you will work in something with the i18n (the languages)? Like adding or modifying some key.

I'm thinking to do a cleanup of some of the unused keys and also organize them to match en.json order.

@gtsteffaniak gtsteffaniak mentioned this pull request Dec 13, 2025
@gtsteffaniak
Copy link
Owner

What do you mean? You could update translation script to enforce the same order keys in all files based on en.json and reorganize en.json.

https://github.com/gtsteffaniak/filebrowser/blob/main/frontend/scripts/sync-translations.js

All seems reasonable to me. Anything else you are thinking?

@Kurami32
Copy link
Collaborator Author

Well, aside of that, I'm thinking in fix some bugs that I noticed.

  • Quick Jump listing item order doesn't match the order of ListingView (the main page) - Names with special characters (like [] ) are last.
  • In plyr, sometimes the videos still with the captions of the previous video.
  • This one is new and maybe you noticed it too: You can't select another path in the file watcher tool, you can only select the files from the root of the source.

I also have and idea for a new future feature (that could go for v2.0 when the max media mode exists), which is about to be able to play or view playlists files. But I don't know much about Go yet, so will remain as idea until then 😅.

btw, merry Christmas!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants