-
Notifications
You must be signed in to change notification settings - Fork 253
Fix/Improve some behaviors in nextPrevious #1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
also noticed another thing... but not sure if is intended or is a bug (?). Is related to the filebrowser/frontend/src/components/files/nextPrevious.vue Lines 927 to 945 in de6fefa
Looks like is to list the sibling directories when opening file list from the previous (left) button, but I think that I've never saw that working. We should fix it? or both buttons should do the same thing? Cuz right now opening the file list from both buttons (next and previous) open the same file listing. |
|
yeah great point thats definitely an issue, lets remove that condition in this PR too. just do |
|
I think the nextPrevious should only allow files not folders, can we add a simple filter for type != "directory" ? |
|
I not added that to the PR (I was just testing and commenting how looks like if were fixed 😅) I removed the condition like you said and both open the file listing, all is still behaving the same. 2025-12-10.15-13-55.mp4 |
|
yep looks good now, thanks for finding that and fixing it :) |
|
Yeah, but was more a misunderstanding. I think that I should have worded the comment better... sorry for that. Well, unrelated but you will work in something with the i18n (the languages)? Like adding or modifying some key. I'm thinking to do a cleanup of some of the unused keys and also organize them to match |
|
What do you mean? You could update translation script to enforce the same order keys in all files based on en.json and reorganize en.json. All seems reasonable to me. Anything else you are thinking? |
|
Well, aside of that, I'm thinking in fix some bugs that I noticed.
I also have and idea for a new future feature (that could go for v2.0 when the max media mode exists), which is about to be able to play or view playlists files. But I don't know much about Go yet, so will remain as idea until then 😅. btw, merry Christmas!! :) |

Description
I'm not sure if counts as improvement or fix, but this should accomplish 3 things:
In mobile, when in media mode, the navigation was being triggered 2 times, skipping 1 file in the queue each time that you pressed the buttons.
In mobile, long pressing the buttons was triggering navigation, making difficult to open the file list if you don't swipe fast. Now if you long press and if you don't move your finger, after release the tap will trigger navigation, but if you swipe a bit (but not enough to open the file list) will return the button to its position.
In desktop, if you dragged the buttons with the mouse but the drag was not enough to open the file list, was triggering navigation. Now just returns to its original position instead.
According to the contributing guide, A PR should contain:
Additional Details
Now fast-forward/rewind shortcuts in the media player should work fine, even if is paused 👍
Since before was checking if the media was playing to handle (or not) the arrow keys.