Skip to content

Conversation

@Kurami32
Copy link
Collaborator

Description
This should fix 3 things:

  • Blank space in normal view in the last row in big screens
  • Drag and drop in folders not refreshing the list
  • And detect if the drag is in a folder, not in a item

According to the contributing guide, A PR should contain:

  • A clear description of why it was opened.
  • A short title that best describes the change.
  • Must pass unit and integration tests, which can be run checked locally prior to opening a PR.
  • Any additional details for functionality not covered by tests.

Additional Details

@Kurami32
Copy link
Collaborator Author

Not sure if is a real timeout error, or if is something related to the changes (?)

@gtsteffaniak
Copy link
Owner

the share test? I notice its been flaky, I think I have a fix in the other PR i just added.

@Kurami32
Copy link
Collaborator Author

Kurami32 commented Nov 24, 2025

btw, after merging the branch in some places the refresh is not working again.
eg: CTRL X + CTRL V, maybe you removed mutations.setReload(true);?

@gtsteffaniak
Copy link
Owner

I did remove a setReload that was happening during copyMove prompt on new folder additon that wasn't needed but nothing in listing view I don't think.

You can add back whatever is needed on listingView.vue

@Kurami32
Copy link
Collaborator Author

Kurami32 commented Nov 24, 2025

well, I think that you removed it from copyPasteConfirm too, that's why when clicking copy is not refreshing.

Edit: I'll add it in Listing view - so no problem.

@gtsteffaniak
Copy link
Owner

maybe so, it shouldn't be in copyPasteConfirm, but the parent action that called it.

Otherwise you get double refreshes -- like copyMove does its own refresh, but if theres a copyMove action then another copyPasteConfirm prompt, thats two refreshes that would happen.

@Kurami32
Copy link
Collaborator Author

Kurami32 commented Nov 24, 2025

Yup, I added it in ListingView.vue, now I'm trying to figure why the replace-rename prompt is not working, all the files are overwrited without ask. Before the merge this was working too.

Edit: So, is odd, is working now...

@gtsteffaniak
Copy link
Owner

hmm the overwrite issue should be fixed in v1.1.1 as one of the bugfixes, the fix was on the backend and affected only files smaller than the chunk size (like folders and new files).

Now the backend will overwrite only if overwrite=true is sent in the api request params

@Kurami32
Copy link
Collaborator Author

Now should be fine.

@gtsteffaniak gtsteffaniak merged commit fa8ceb5 into dev/v1.1.1 Nov 24, 2025
17 checks passed
@gtsteffaniak gtsteffaniak deleted the fix-normal-view branch November 24, 2025 18:12
@gtsteffaniak gtsteffaniak mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants