-
Notifications
You must be signed in to change notification settings - Fork 253
Fix drag and drop and rows in normal view #1651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure if is a real timeout error, or if is something related to the changes (?) |
|
the share test? I notice its been flaky, I think I have a fix in the other PR i just added. |
|
btw, after merging the branch in some places the refresh is not working again. |
|
I did remove a setReload that was happening during copyMove prompt on new folder additon that wasn't needed but nothing in listing view I don't think. You can add back whatever is needed on listingView.vue |
|
well, I think that you removed it from copyPasteConfirm too, that's why when clicking copy is not refreshing. Edit: I'll add it in Listing view - so no problem. |
|
maybe so, it shouldn't be in copyPasteConfirm, but the parent action that called it. Otherwise you get double refreshes -- like copyMove does its own refresh, but if theres a copyMove action then another copyPasteConfirm prompt, thats two refreshes that would happen. |
|
Yup, I added it in Edit: So, is odd, is working now... |
|
hmm the overwrite issue should be fixed in v1.1.1 as one of the bugfixes, the fix was on the backend and affected only files smaller than the chunk size (like folders and new files). Now the backend will overwrite only if overwrite=true is sent in the api request params |
|
Now should be fine. |
Description
This should fix 3 things:
According to the contributing guide, A PR should contain:
Additional Details