Skip to content

Conversation

@Kurami32
Copy link
Collaborator

@Kurami32 Kurami32 commented Sep 2, 2025

Description
Continuation of #1166
I worked on the dev/0.8.4 branch.

According to the contributing guide, A PR should contain:

  • A clear description of why it was opened.
  • A short title that best describes the change.
  • Must pass unit and integration tests, which can be run checked locally prior to opening a PR.
  • Any additional details for functionality not covered by tests.

Additional Details
Before add the metadata on the audio player I organized a bit the file, added some comments, fixed some issues on the media player and added the "fallback image" on the audio player but without the metadata yet (I let some things commented for work later there), so~ right now all the audio previews look like this:

image

I updated the translation for spanish too.

@Kurami32
Copy link
Collaborator Author

Kurami32 commented Sep 2, 2025

Hmm... I don't modified nothing from backend. I only cloned the 0.8.4 branch and made changes there.

@Kurami32 Kurami32 changed the title Small fixes / additions Small fixes / additions on the media player Sep 2, 2025
@gtsteffaniak
Copy link
Owner

gtsteffaniak commented Sep 2, 2025

adjusted the display to be centered , otherwise it looks good to me. I'll merge if you have no other changes

@Kurami32
Copy link
Collaborator Author

Kurami32 commented Sep 2, 2025

adjusted the display to be centered , otherwise it looks good to me. I'll merge if you have no other changes

Thanks! And for now I don't have other changes, you can merge this. I'm still figuring how to implement the metadata.

@gtsteffaniak gtsteffaniak merged commit 1a36bc7 into gtsteffaniak:dev/v0.8.4 Sep 2, 2025
22 of 23 checks passed
@gtsteffaniak
Copy link
Owner

great! I'll keep an eye out for any other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants